Closed Bug 939044 Opened 11 years ago Closed 11 years ago

Get rid of MODULE

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(4 files, 2 obsolete files)

Rename remaining MODULE definitions to XPIDL_MODULE
(deleted), patch
mshal
: review+
Details | Diff | Splinter Review
Remove most definitions of MODULE
(deleted), patch
mshal
: review+
Details | Diff | Splinter Review
Make the build frontend and backend forget about MODULE
(deleted), patch
gps
: review+
Details | Diff | Splinter Review
Remove the last uses of the MODULE variable in makefiles
(deleted), patch
gps
: review+
Details | Diff | Splinter Review
MODULE is now almost useless. Let's kill it for good.
I think this is a good enough approximation.
Attachment #832794 - Flags: review?(gps)
Attached patch Remove most definitions of MODULE (obsolete) (deleted) — — Splinter Review
Attachment #832796 - Flags: review?(mshal)
Attachment #832798 - Flags: review?(mshal)
Attachment #832804 - Flags: review?(mshal)
Attachment #832796 - Attachment is obsolete: true
Attachment #832796 - Flags: review?(mshal)
There were a bit more than expected.
Attachment #832852 - Flags: review?(gps)
Attachment #832794 - Attachment is obsolete: true
Attachment #832794 - Flags: review?(gps)
Attachment #832798 - Flags: review?(mshal) → review+
Comment on attachment 832804 [details] [diff] [review] Remove most definitions of MODULE >diff --git a/dom/icc/tests/moz.build b/dom/icc/tests/moz.build >--- a/dom/icc/tests/moz.build >+++ b/dom/icc/tests/moz.build >@@ -1,8 +1,6 @@ > # -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*- > # vim: set filetype=python: > # This Source Code Form is subject to the terms of the Mozilla Public > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > >-MODULE = 'test_dom_icc' >- Does this moz.build file still need to exist? It's now empty and there's no Makefile.in
Attachment #832804 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #7) > Does this moz.build file still need to exist? It's now empty and there's no > Makefile.in Empty moz.build need to exist.
Attachment #832852 - Flags: review?(gps) → review+
Attachment #832808 - Flags: review?(gps) → review+
Blocks: 951352
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: