Gene Lian (I already quit Mozilla) Reporter
	Description • 11 years ago

The following are our indexes for DB:

  objectStore.createIndex("appId", "appId", { unique: false }); 
  objectStore.createIndex("network", "network", { unique: false });
  objectStore.createIndex("networkType", "networkType", { unique: false });
  objectStore.createIndex("timestamp", "timestamp", { unique: false });
  objectStore.createIndex("rxBytes", "rxBytes", { unique: false });
  objectStore.createIndex("txBytes", "txBytes", { unique: false });
  objectStore.createIndex("rxTotalBytes", "rxTotalBytes", { unique: false });
  objectStore.createIndex("txTotalBytes", "txTotalBytes", { unique: false });

However, we only used "network" to do searching and the rest is not used. I believe removing the redundant ones can speed up our metering performance because less indexes have to be updated at run-time.

	John Shih Assignee
	Comment 1 • 11 years ago

Since I'm working on bug 922926, which is related to this bug (both work on DB part).
I'll take this one.

	Gene Lian (I already quit Mozilla) Reporter
	Comment 3 • 11 years ago

Comment on attachment 8335166 [details] [diff] [review]
Bug 939061 - Remove redundant indexes in NetworkStatsDB.jsm. r=gene

Review of attachment 8335166 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me bug I hope to see Albert's feedback as well before landing. We have to be very careful about the change of updating DB schema.

::: dom/network/src/NetworkStatsDB.jsm
@@ +91,5 @@
>          if (DEBUG) {
>            debug("Created object stores and indexes for version 3");
>          }
> +      } else if (currVersion == 3) {
> +        // Delete redundent indexes.

// Delete redundent indexes (leave "network" only).

@@ +94,5 @@
> +      } else if (currVersion == 3) {
> +        // Delete redundent indexes.
> +        if (!objectStore) {
> +          objectStore = aTransaction.objectStore(STORE_NAME);
> +        }

I'd prefer just doing:

objectStore = aTransaction.objectStore(STORE_NAME);

without checking the previous assignment to make the logic more clear.

	Albert [:albert]
	Comment 4 • 11 years ago

Comment on attachment 8335166 [details] [diff] [review]
Bug 939061 - Remove redundant indexes in NetworkStatsDB.jsm. r=gene

All tests passed, it's fine. Just needs a rebase.

For me is ok.

	John Shih Assignee
	Comment 5 • 11 years ago

r=gene

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/806acbcc5207

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/806acbcc5207