Open
Bug 939178
Opened 11 years ago
Updated 2 years ago
using weakPtrs with webidl objects could be easier (make a central do_QueryObjectReferent() function)
Categories
(Core :: DOM: Core & HTML, defect, P5)
Tracking
()
NEW
People
(Reporter: jib, Unassigned)
References
Details
The following should be generalized: // do_QueryObjectReferent() - Helps get PeerConnectionObserver from nsWeakPtr. // // nsWeakPtr deals in XPCOM interfaces, while webidl bindings are concrete objs. // TODO: Turn this into a central (template) function somewhere. // // Without it, each weak-ref call in this file would look like this: // // nsCOMPtr<nsISupportsWeakReference> tmp = do_QueryReferent(mPCObserver); // nsRefPtr<nsSupportsWeakReference> tmp2 = do_QueryObject(tmp); // nsRefPtr<PeerConnectionObserver> pco = static_cast<PeerConnectionObserver*>(&*tmp2); // if (!pco) { // return; // } static already_AddRefed<PeerConnectionObserver> do_QueryObjectReferent(nsIWeakReference* aRawPtr) { nsCOMPtr<nsISupportsWeakReference> tmp = do_QueryReferent(aRawPtr); nsRefPtr<nsSupportsWeakReference> tmp2 = do_QueryObject(tmp); nsRefPtr<PeerConnectionObserver> tmp3 = static_cast<PeerConnectionObserver*>(&*tmp2); return tmp3.forget(); }
Comment 1•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046 Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5. If you have questions, please contact :mdaly.
Priority: -- → P5
Assignee | ||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•