Closed Bug 939271 Opened 11 years ago Closed 11 years ago

Move various mochitests to manifests

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [qa-])

Attachments

(13 files, 1 obsolete file)

Part a: hal
(deleted), patch
mounir
: review+
Details | Diff | Splinter Review
Part b: caps
(deleted), patch
bholley
: review-
Details | Diff | Splinter Review
Part c: browser/devtools/styleinspector/test
(deleted), patch
mshal
: review+
Details | Diff | Splinter Review
Part d: toolkit/content/tests/widgets
(deleted), patch
mshal
: review+
Details | Diff | Splinter Review
Part e: toolkit/components/social/test/browser
(deleted), patch
mshal
: review+
Details | Diff | Splinter Review
Part f: js/xpconnect
(deleted), patch
bholley
: review+
Details | Diff | Splinter Review
Part g: gfx/tests
(deleted), patch
roc
: review+
Details | Diff | Splinter Review
Part h: parser
(deleted), patch
hsivonen
: review+
Details | Diff | Splinter Review
Part i: crashreporter
(deleted), patch
ted
: review+
Details | Diff | Splinter Review
Part j: widget
(deleted), patch
roc
: review+
Details | Diff | Splinter Review
Part k: browser/devtools/commandline
(deleted), patch
mshal
: review+
Details | Diff | Splinter Review
Part l: browser/devtools/debugger
(deleted), patch
mshal
: review+
Details | Diff | Splinter Review
Part m: accessible/tests/mochitest
(deleted), patch
tbsaunde
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch Part a: hal (deleted) — — Splinter Review
The test is listed both in hal/Makefile.in and hal/tests/browser.ini, so it's being run twice.
Attachment #833129 - Flags: review?(mounir)
Attached patch Part b: caps (deleted) — — Splinter Review
Attachment #833130 - Flags: review?(bobbyholley+bmo)
Attachment #833131 - Flags: review?(mshal)
Attachment #833133 - Flags: review?(mshal)
Attachment #833134 - Flags: review?(mshal)
Comment on attachment 833130 [details] [diff] [review] Part b: caps Review of attachment 833130 [details] [diff] [review]: ----------------------------------------------------------------- I already did this in bug 939166.
Attachment #833130 - Flags: review?(bobbyholley+bmo) → review-
Comment on attachment 833131 [details] [diff] [review] Part c: browser/devtools/styleinspector/test >diff --git a/browser/devtools/styleinspector/test/Makefile.in b/browser/devtools/styleinspector/test/Makefile.in >-MOCHITEST_BUG_677940_DATA_FILES = \ >+mochitest_bug_677940_data_FILES = \ > browser_styleinspector_bug_677930_urls_clickable/browser_styleinspector_bug_677930_urls_clickable.css \ > $(NULL) >-MOCHITEST_BUG_677940_DATA_DEST = $(MOCHITEST_BROWSER_DEST)/browser_styleinspector_bug_677930_urls_clickable >-INSTALL_TARGETS += MOCHITEST_BUG_677940_DATA >+mochitest_bug_677940_data_DEST = $(mochitest_browser_dest)/browser_styleinspector_bug_677930_urls_clickable >+INSTALL_TARGETS += mochitest_bug_677940_data I think all '677940' numbers should be '677930'
Attachment #833131 - Flags: review?(mshal) → review+
Attachment #833133 - Flags: review?(mshal) → review+
Attachment #833134 - Flags: review?(mshal) → review+
Attached patch Part f: js/xpconnect (deleted) — — Splinter Review
Attachment #833429 - Flags: review?(bobbyholley+bmo)
Attached patch Part g: gfx/tests (deleted) — — Splinter Review
Attachment #833430 - Flags: review?(roc)
Attached patch Part h: parser (deleted) — — Splinter Review
Attachment #833432 - Flags: review?(hsivonen)
Attached patch Part i: crashreporter (deleted) — — Splinter Review
Attachment #833436 - Flags: review?(ted)
Attached patch Part j: widget (deleted) — — Splinter Review
Attachment #833437 - Flags: review?(roc)
Attachment #833444 - Flags: review?(mshal)
Attachment #833445 - Flags: review?(mshal)
Attached patch Part m: accessible/tests/mochitest (obsolete) (deleted) — — Splinter Review
Attachment #833446 - Flags: review?(trev.saunders)
(In reply to Bobby Holley (:bholley) from comment #6) > Comment on attachment 833130 [details] [diff] [review] > Part b: caps > > Review of attachment 833130 [details] [diff] [review]: > ----------------------------------------------------------------- > > I already did this in bug 939166. Bug 840488, that is.
Attachment #833446 - Attachment is obsolete: true
Attachment #833446 - Flags: review?(trev.saunders)
Attachment #833455 - Flags: review?(trev.saunders)
Comment on attachment 833432 [details] [diff] [review] Part h: parser rs=hsivonen.
Attachment #833432 - Flags: review?(hsivonen) → review+
Comment on attachment 833455 [details] [diff] [review] Part m: accessible/tests/mochitest >diff --git a/accessible/tests/mochitest/tree/a11y.ini b/accessible/tests/mochitest/tree/a11y.ini >new file mode 100644 >--- /dev/null >+++ b/accessible/tests/mochitest/tree/a11y.ini I'm not sure what the point would be but should these files need license notices? (they use rather odd format too) >@@ -0,0 +1,40 @@ >+[DEFAULT] >+support-files = >+ dockids.html >+ wnd.xul >+ >+[test_applicationacc.xul] >+skip-if = true # Bug 561508 >+[test_aria_globals.html] >+[test_aria_grid.html] >+[test_aria_imgmap.html] >+[test_aria_list.html] >+[test_aria_menu.html] >+[test_aria_presentation.html] >+[test_brokencontext.html] >+[test_button.xul] >+[test_canvas.html] >+[test_combobox.xul] >+[test_cssoverflow.html] >+[test_dochierarchy.html] >+[test_dockids.html] >+[test_filectrl.html] >+[test_formctrl.html] >+[test_formctrl.xul] >+[test_gencontent.html] >+[test_groupbox.xul] >+[test_iframe.html] >+[test_img.html] >+[test_invalid_img.xhtml] >+[test_invalidationlist.html] >+[test_list.html] >+[test_map.html] >+[test_media.html] >+[test_select.html] >+[test_tabbox.xul] >+[test_tabbrowser.xul] >+[test_table.html] >+[test_tree.xul] >+[test_txtcntr.html] >+[test_txtctrl.html] >+[test_txtctrl.xul] >diff --git a/accessible/tests/mochitest/tree/moz.build b/accessible/tests/mochitest/tree/moz.build >deleted file mode 100644 >--- a/accessible/tests/mochitest/tree/moz.build >+++ /dev/null >@@ -1,6 +0,0 @@ >-# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*- >-# vim: set filetype=python: >-# This Source Code Form is subject to the terms of the Mozilla Public >-# License, v. 2.0. If a copy of the MPL was not distributed with this >-# file, You can obtain one at http://mozilla.org/MPL/2.0/. >-
Attachment #833455 - Flags: review?(trev.saunders) → review+
Attachment #833429 - Flags: review?(bobbyholley+bmo) → review+
Attachment #833444 - Flags: review?(mshal) → review+
Comment on attachment 833445 [details] [diff] [review] Part l: browser/devtools/debugger >diff --git a/browser/devtools/debugger/test/browser.ini b/browser/devtools/debugger/test/browser.ini >+[browser_dbg_break-on-dom-event.js] >+skip-if = os == "mac" # Bug 895426 >+[browser_dbg_event-listeners.js] >+skip-if = os == "mac" Maybe add '# Bug 895426' to the last line as well? It's not so obvious that it applies to both.
Attachment #833445 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #20) > Comment on attachment 833445 [details] [diff] [review] > Part l: browser/devtools/debugger > > >diff --git a/browser/devtools/debugger/test/browser.ini b/browser/devtools/debugger/test/browser.ini > >+[browser_dbg_break-on-dom-event.js] > >+skip-if = os == "mac" # Bug 895426 > >+[browser_dbg_event-listeners.js] > >+skip-if = os == "mac" > > Maybe add '# Bug 895426' to the last line as well? It's not so obvious that > it applies to both. According to the comment in the makefile, it doesn't apply to both.
(In reply to :Ms2ger from comment #21) > (In reply to Michael Shal [:mshal] from comment #20) > > Maybe add '# Bug 895426' to the last line as well? It's not so obvious that > > it applies to both. > > According to the comment in the makefile, it doesn't apply to both. I was looking at the title of bug 895426, which mentions both tests. Though maybe not because of https://bugzilla.mozilla.org/show_bug.cgi?id=895426#c233
Attachment #833436 - Flags: review?(ted) → review+
Comment on attachment 833129 [details] [diff] [review] Part a: hal Review of attachment 833129 [details] [diff] [review]: ----------------------------------------------------------------- I guess browser.ini is a new thing. Never heard about it before ;) rs=me
Attachment #833129 - Flags: review?(mounir) → review+
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: