Closed
Bug 939414
Opened 11 years ago
Closed 11 years ago
Implement memory stat dumping for browser-chrome
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: shu, Assigned: shu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Following in the format of bug 939137, we should also dump memory stat for BC.
Since 99% of the time we care about the main process, only dump for the main process in BC for now.
Should also print resident in addition to vsize and maximum contiguous VM block.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → shu
Whiteboard: [MemShrink]
Assignee | ||
Comment 1•11 years ago
|
||
Cargo culting all the stuff about the plain mochitest harness. No idea what the
steps are to ensuring that the new MemoryStats.js file gets loaded in the right
places, so please check that for me.
Attachment #833415 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 833415 [details] [diff] [review]
wip
Flipping review to ted for the harness stuff.
Attachment #833415 -
Flags: review?(nfroyd) → review?(ted)
Assignee | ||
Comment 3•11 years ago
|
||
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=21f3282d636e
Assignee | ||
Comment 4•11 years ago
|
||
Viewer is here: http://people.mozilla.org/~sguo/mochimem/
Comment 5•11 years ago
|
||
(In reply to Shu-yu Guo [:shu] from comment #4)
> Viewer is here: http://people.mozilla.org/~sguo/mochimem/
Woah, that's awesome. There are a few places in bc where contiguous memory drops, though nothing as dramatic as M2.
Comment 6•11 years ago
|
||
Comment on attachment 833415 [details] [diff] [review]
wip
Review of attachment 833415 [details] [diff] [review]:
-----------------------------------------------------------------
I like putting everything into MemoryStats.js; I'll have to use that for my upcoming DMD/about:memory stuff.
::: testing/mochitest/tests/SimpleTest/MemoryStats.js
@@ +13,5 @@
> +var MEM_STAT_SUPPORTED = 2;
> +
> +MemoryStats._hasMemoryStatistics = {}
> +MemoryStats._hasMemoryStatistics.vsize = MEM_STAT_UNKNOWN;
> +MemoryStats._hasMemoryStatistics.resident = MEM_STAT_UNKNOWN;
Please use residentFast; .resident has poor behavior on OS X.
Updated•11 years ago
|
Attachment #833415 -
Flags: review?(ted) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•7 years ago
|
Component: Mochitest Chrome → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•