We need to convert the SVG textPath code from gfxPath to Moz2D Path.

I've not bothered spending time on the old SVG text code since I'm hoping that will just be ripped out soon.

I just noticed the comment in bug 889736 about not wanting to take those patches until after the December uplift. Guess I better fix nsSVGGlyphFrame too then.

Comment on attachment 8333561 [details] [diff] [review] patch Review of attachment 8333561 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/svg/nsSVGGlyphFrame.cpp @@ +783,5 @@ > + Point normal(-tangent.y, tangent.x); // Unit vector normal to the point. > + Point offsetFromPath = normal * pos.y; > + cp[i].pos = ThebesPoint(pt + offsetFromPath) - > + ThebesPoint(tangent) * halfAdvance; > + double glyphRotation = atan2(tangent.y, tangent.x); Use atan2f. ::: layout/svg/nsSVGTextFrame2.cpp @@ +4808,5 @@ > > // Position the character on the path at the right angle. > + Point tangent; // Unit vector tangent to the point we find. > + Point pt = path->ComputePointAtLength(Float(midx), &tangent); > + double glyphRotation = atan2(tangent.y, tangent.x); Use atan2f and make the variable a float (or Float). Either leave the variable with its old name, "angle", or use "rotation". All the variables around here are to do with the glyph, so I don't think it needs to be in the name.

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe2eb1dbf2ac https://hg.mozilla.org/integration/mozilla-inbound/rev/4e64c6bb2732

Hmmmmmmm....switching to atan2f caused a slight difference in the positioning of textPath text, causing some failures on Mochitest 1: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4e64c6bb2732 I _think_ that's probably okay so I marked the tests as fuzzy: https://hg.mozilla.org/integration/mozilla-inbound/rev/67278f262497 However, CC'ing some people so they're aware of this.

The important thing to note being that the switch from double precision float to single precision float can cause us to no longer get nice round integer results when they might be expected.

https://hg.mozilla.org/mozilla-central/rev/fe2eb1dbf2ac https://hg.mozilla.org/mozilla-central/rev/4e64c6bb2732 https://hg.mozilla.org/mozilla-central/rev/67278f262497