939643 - Intermittent browser_blocklist.js | Found an unexpected Addons:Blocklist at the end of test run

Reporter

Description

•

11 years ago

https://tbpl.mozilla.org/php/getParsedLog.php?id=30674890&tree=Mozilla-Inbound Rev3 Fedora 12 mozilla-inbound debug test mochitest-browser-chrome on 2013-11-17 16:43:13 PST for push 095e5b582f53 slave: talos-r3-fed-101 17:06:36 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | finished in 5204ms 17:06:36 INFO - TEST-INFO | checking window state 17:06:36 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Found an unexpected Addons:Blocklist at the end of test run

Comment hidden (Legacy TBPL/Treeherder Robot)

Ryan VanderMeulen [:RyanVM]

Comment 8

•

11 years ago

Mark or Shane, does one of you have some time to take a look at this relatively-recent regression?

Mark Hammond [:markh] [:mhammond]

Comment 9

•

11 years ago

Attached patch 0001-Bug-939643-avoid-test-orange-by-rejigging-how-we-wai.patch (deleted) — Details — Splinter Review

It looks like, for some reason, the blocklist window isn't getting focus in some cases. Also, the existing unload handler must be firing - but may well be firing for about:blank unloading before the real content is loaded. The test doesn't really need to wait for focus, so this patch tweaks it to (a) wait for load before closing it and (b) don't add the unload handler until load has fired. Test passes locally and a Linux only try is at https://tbpl.mozilla.org/?tree=Try&rev=7b4d4d5c3f99, which I'll re-trigger a few times. Seeing I'm such an optimist, I'm assuming this will fix it, so asking Shane for review.

Attachment #8338163 - Flags: review?(mixedpuppy)

Luke Wagner [:luke]

Comment 10

•

11 years ago

My patch in bug 931864 seems to change timing/scheduling enough to make this failure much more frequent. Fortunately, the posted patch seems to fix the problem! Nice!

Blocks: 931864

Shane Caraveo (:mixedpuppy)

Comment 11

•

11 years ago

Comment on attachment 8338163 [details] [diff] [review] 0001-Bug-939643-avoid-test-orange-by-rejigging-how-we-wai.patch lgtm

Attachment #8338163 - Flags: review?(mixedpuppy) → review+

Mark Hammond [:markh] [:mhammond]

Updated

•

11 years ago

Keywords: checkin-needed

Comment hidden (Legacy TBPL/Treeherder Robot)

Ryan VanderMeulen [:RyanVM]

Comment 15

•

11 years ago

https://hg.mozilla.org/integration/fx-team/rev/8737eca5b787

Flags: in-testsuite+

Keywords: checkin-needed

Whiteboard: [fixed-in-fx-team]

Comment hidden (Legacy TBPL/Treeherder Robot)

Ryan VanderMeulen [:RyanVM]

Comment 17

•

11 years ago

https://hg.mozilla.org/mozilla-central/rev/8737eca5b787

Status: NEW → RESOLVED

Closed: 11 years ago

Resolution: --- → FIXED

Whiteboard: [fixed-in-fx-team]

Target Milestone: --- → Firefox 28

Comment hidden (Legacy TBPL/Treeherder Robot)

RyanVM https://tbpl.mozilla.org/php/getParsedLog.php?id=31337163&tree=B2g-Inbound Rev3 Fedora 12 b2g-inbound debug test mochitest-browser-chrome on 2013-12-02 12:07:19 revision: f9d8f53e8739 slave: talos-r3-fed-082 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Found an unexpected Addons:Blocklist at the end of test run TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | tooltipState (for ' ') - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | outputState (for ' ') - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | tooltipState (for 'tsb ') - Got false:notHasFocus, expected true:importantFieldFlag TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | outputState (for 'tsb ') - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | tooltipState (for 'tsb t') - Got false:notHasFocus, expected true:importantFieldFlag TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | outputState (for 'tsb t') - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | tooltipState (for 'tsb tt') - Got false:notHasFocus, expected true:importantFieldFlag TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | outputState (for 'tsb tt') - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | tooltipState (for 'wxqy') - Got false:notHasFocus, expected true:isError TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | outputState (for 'wxqy') - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | tooltipState - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_tooltip.js | outputState - Got false:notHasFocus, expected false:default TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/satchel/test/browser/browser_privbrowsing_perwindowpb.js | Test timed out

Ryan VanderMeulen [:RyanVM]

Updated

•

11 years ago

status-firefox26: --- → unaffected

status-firefox27: --- → unaffected

status-firefox28: --- → fixed

status-firefox-esr24: --- → unaffected

Comment hidden (Legacy TBPL/Treeherder Robot)

BMO Automation

Updated

•

6 years ago

Product: Firefox → Firefox Graveyard