Closed Bug 940202 Opened 11 years ago Closed 11 years ago

FINAL_LIBRARY and comm-central don't quite get along

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: jcranmer, Assigned: jcranmer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Discussed over IRC. The main problem is that toolkit/library/backend.mk ends up with SHARED_LIBRARY_LIBS += $(DEPTH)/mailnews ... which doesn't exist. Patch in hand, just making sure it compiles locally before uploading.
Blocks: 940204
Attached patch Carry around topobjdir of libraries (obsolete) (deleted) — Splinter Review
This builds comm-central for me. Mozilla-central passes configure, so I assume it works there too.
Attachment #8334348 - Flags: review?(mh+mozilla)
Comment on attachment 8334348 [details] [diff] [review] Carry around topobjdir of libraries Review of attachment 8334348 [details] [diff] [review]: ----------------------------------------------------------------- I think the data and emitter parts would be greatly simplified if you just stored by OBJDIR where we currently store by RELATIVEDIR.
Attachment #8334348 - Flags: review?(mh+mozilla) → review-
Attachment #8334348 - Attachment is obsolete: true
Attachment #8334360 - Flags: review?(mh+mozilla)
Comment on attachment 8334360 [details] [diff] [review] Fix the problem as discussed over IRC Review of attachment 8334360 [details] [diff] [review]: ----------------------------------------------------------------- If that doesn't already exist, please file a tracking bug for things that can be removed once c-c is under m-c, and make this bug block it. ::: python/mozbuild/mozbuild/backend/recursivemake.py @@ +1076,5 @@ > + # directory instead of $(DEPTH). > + if objdir.startswith(topobjdir + '/'): > + relpath = '$(DEPTH)/%s' % os.path.relpath(objdir, topobjdir) > + else: > + relpath = os.path.relpath(objdir, thisobjdir) make that mozpath.relpath instead of os.path.relpath.
Attachment #8334360 - Flags: review?(mh+mozilla) → review+
Blocks: 940222
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: