Comment on attachment 8334491 [details] patch Looks ok to me

Kaze, Could you please review that patch? Due to several issues in Settings app, like elements in absolute position which make the lists difficult to scale at a markup level, we wanted to try using flex box. This patch only applies to Settings root, as part of a metabug. If this structure make sense to you, we will extend it to the whole app. Thanks!

It should be landed in version 1.3, otherwise we will get a worse user experience and making more difficult to scale

(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #4) > It should be landed in version 1.3, otherwise we will get a worse user > experience and making more difficult to scale Exactly how is this a regression?

Comment on attachment 8334491 [details] patch Arthur, Evelyn, is it possible for you to review the patch in place of Kaze?

(In reply to Jason Smith [:jsmith] from comment #5) > (In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #4) > > It should be landed in version 1.3, otherwise we will get a worse user > > experience and making more difficult to scale > > Exactly how is this a regression? Because most of the defects did not appear in previous release

Comment on attachment 8334491 [details] patch Pavel, could you provide inputs on this patch? Arnau, could you share what bugs the patch are trying to solve and plans of the following patches after this one?

There are several bugs, I'll do further research, and add them to the blocking bugs list. One of them is 908300. The thing is that lists in Settings app are difficult to work with, and flex box which was not in gecko when Settings app was build, will allow us to create more flexible layouts.

How is review going? Is it everything ok?

We were adding panels in settings app for the DSDS features of v1.3 in the past few days. I would like to make those patches landed before this one as DSDS is one of the major committed features of v1.3. Plan to review this patch next week.

(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #7) > Because most of the defects did not appear in previous release Triage: From reading the comment we are unable to determine the severity of the UI breakage. Also, we may not want to take a proper fix for v1.3 at this late stage of the release. We recommend this bug to be worked on v1.4 release so it can be done properly. Please re-nom if anyone have more information to comment.

Comment on attachment 8334491 [details] patch Kaze, could you take a look at this structure change as I am not that familiar with building blocks. Thanks.

Comment on attachment 8334491 [details] patch I like the HTML markup but I left some comments for the CSS part on your PR.

Comment on attachment 8334491 [details] patch Looks OK, but please see the nits from Kaze and Kevin

Shouldn't be a blocker for 1.4.

Bruce, I don't thing this should block 1.4. This patch is an improvement for markup in settings, which will allow us to have a more flexible layout options, and the first patch of the meta 940353. I don't think we will have time to finish the meta on time for 1.4. I think we should not make it blocker for 965889.

Even if this is not blocking, have the nits referenced in comment #15 been addressed? Bug #908309 needs this one. Thanks for any update; just tracking what will and will not make it into 1.4 and will be carried over for 1.5/2.0.

Even if it's not blocking, what is the status here? Should it be resolved invalid? This is still noted as being for Sprint 1 but hasn't moved.

Reassigning to Pavel based on Rafa direction.

Firefox OS is not being worked on