Closed
Bug 940542
Opened 11 years ago
Closed 10 years ago
Convert to Promise.jsm in the inspector
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: bbenvie, Assigned: sjakthol)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Here's a patch that replaces deprecated-sync-thenables with Promise.jsm in inspector/*.
Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=66e777dbf7f0
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8537297 [details] [diff] [review]
inspector-deprecated-sync-thenables.patch
Review of attachment 8537297 [details] [diff] [review]:
-----------------------------------------------------------------
Code changes are simple enough for a quick R+, and try seems to be happy, so moving to promise.jsm didn't seem to have unexpected consequences.
Attachment #8537297 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•