Closed
Bug 940713
Opened 11 years ago
Closed 11 years ago
Enable autoclose brackets for source editor
Categories
(DevTools :: Source Editor, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 28
People
(Reporter: gl, Assigned: gl)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
anton
:
review+
|
Details | Diff | Splinter Review |
Codemirror provides an option to autoclose brackets. This would be useful for the scratchpad and style editor.
|
Assignee | |
Comment 1•11 years ago
|
||
WIP patch. I think the feature should be disabled in the inspector.
|
|
Assignee | |
Comment 2•11 years ago
|
||
After discussing with Anton, disregard disabling for the inspector (editing outer html). This would be useful for inline javascript.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Currently, looking into unit tests for this add-on.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Updated•11 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 5•11 years ago
|
||
Probably won't get to the unit tests till next week. I am curious if we could add in the unit tests later since this is a CM add-on (closebrackets.js).
Flags: needinfo?(anton)
|
|
||
Comment 6•11 years ago
|
||
Actually, StyleEditor already uses this addon. So the question is whether we should enable it by default or not. I don't think there's any harm in enabling it by default—given that all current tests pass.
Flags: needinfo?(anton)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8334895 -
Flags: review?(anton)
|
|
||
Updated•11 years ago
|
Attachment #8334895 -
Flags: review?(anton) → review+
|
|
||
Comment 7•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Comment 9•11 years ago
|
||
Verified as fixed on latest Aurora 28.0a2 (buildID: 20140131004003) under MAC OSX 10.8.5 32-bit, Ubuntu 32-bit and Win 7 64-bit.
The brackets are autoclosed on Inspector, Scratchpad and Style Editor.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•