Closed
Bug 940783
Opened 11 years ago
Closed 11 years ago
History objects should unconditionally throw if their inner is not current
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bholley, Assigned: bholley)
References
Details
(Keywords: dev-doc-complete, site-compat, Whiteboard: [qa-])
Attachments
(2 files)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Currently we do a subsumes check on the caller, which is more permissive than Hixie wants. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=23359
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8538c271cad7
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8334988 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8334990 -
Flags: review?(bzbarsky)
![]() |
||
Comment 4•11 years ago
|
||
Comment on attachment 8334988 [details] [diff] [review] Throw when accessing properties and methods on history objects in non-active documents. v1 r=me if we think this is web-compatible.
Attachment #8334988 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 5•11 years ago
|
||
Comment on attachment 8334990 [details] [diff] [review] Tests. v1 r=me, but did we not have any tests that verified the old same-origin behavior worked that need fixing?
Attachment #8334990 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #5) > Comment on attachment 8334990 [details] [diff] [review] > Tests. v1 > > r=me, but did we not have any tests that verified the old same-origin > behavior worked that need fixing? It's what IE9 does, so probably.
Assignee | ||
Comment 7•11 years ago
|
||
Green try run in comment 1. remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3cb53fd4a11 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc384ede1d1a
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3cb53fd4a11 https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 9•11 years ago
|
||
Added to the site compat doc: https://developer.mozilla.org/en-US/Firefox/Releases/28/Site_Compatibility
Keywords: dev-doc-complete,
site-compat
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a
Flags: in-testsuite+
Whiteboard: [qa-]
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•