Closed Bug 940783 Opened 11 years ago Closed 11 years ago

History objects should unconditionally throw if their inner is not current

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: bholley, Assigned: bholley)

References

Details

(Keywords: dev-doc-complete, site-compat, Whiteboard: [qa-])

Attachments

(2 files)

Currently we do a subsumes check on the caller, which is more permissive than Hixie wants. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=23359
Attached patch Tests. v1 (deleted) — Splinter Review
Attachment #8334990 - Flags: review?(bzbarsky)
Comment on attachment 8334988 [details] [diff] [review]
Throw when accessing properties and methods on history objects in non-active documents. v1

r=me if we think this is web-compatible.
Attachment #8334988 - Flags: review?(bzbarsky) → review+
Comment on attachment 8334990 [details] [diff] [review]
Tests. v1

r=me, but did we not have any tests that verified the old same-origin behavior worked that need fixing?
Attachment #8334990 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] from comment #5)
> Comment on attachment 8334990 [details] [diff] [review]
> Tests. v1
> 
> r=me, but did we not have any tests that verified the old same-origin
> behavior worked that need fixing?

It's what IE9 does, so probably.
https://hg.mozilla.org/mozilla-central/rev/f3cb53fd4a11
https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Depends on: 943418
https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a
Flags: in-testsuite+
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: