Closed
Bug 940897
Opened 11 years ago
Closed 11 years ago
[settings] built-in keyboard of type 'Number': Type always shown in English (not using localization)
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 fixed)
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | fixed |
People
(Reporter: aryx, Assigned: Pike)
References
Details
(Keywords: l12y, regression, Whiteboard: [3rd-party-keyboard])
Attachments
(1 file)
Boot2Gecko 1.2.0.0-prerelease 20131119224416 on Keon
With a different language than English for the user interface, opening Settings > Keyboards > Selected Keyboards still shows the type of the built-in numbers keyboard as "Number" (in English).
apps/keyboard/manifest.webapp defines only the number keyboard, so that's likely the issue.
Reporter | ||
Comment 1•11 years ago
|
||
The integration into apps/keyboard/manifest.webapp is likely also the reason for the keyboard showing the number layout on initialization when opened for the first time in an app during runtime.
Assignee | ||
Comment 2•11 years ago
|
||
This is a regression from bug 930371, and how the change of entry_points to inputs plays with multilocale.py.
I'll have a PR in a second that I think fixes this, sadly more code in multilocale.py.
blocking-b2g: --- → koi?
Component: Gaia::Settings → Gaia::Keyboard
Depends on: 930371
Keywords: regression
Assignee | ||
Comment 3•11 years ago
|
||
This is only rudimentary tested, i.e., I've run make with LOCALE_BASEDIR and and LOCALES_FILE set, and inspected manifest.webapp to be OK.
Assignee: nobody → l10n
Attachment #8335256 -
Flags: review?(yurenju.mozilla)
Attachment #8335256 -
Flags: review?(rlu)
Updated•11 years ago
|
Whiteboard: [3rd-party-keyboard]
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Comment 4•11 years ago
|
||
Blocking for untranslated number keyboard having significant localization impact
Comment 5•11 years ago
|
||
[off topic] we should land multilocale.js ASAP, but I don't have enough time :(
Updated•11 years ago
|
Comment 6•11 years ago
|
||
Comment on attachment 8335256 [details]
support inputs entry point for the keyboard app
Looks good to me.
Thanks and sorry for the late change of changing entry_points to inputs.
Attachment #8335256 -
Flags: review?(rlu) → feedback+
Comment 7•11 years ago
|
||
Comment on attachment 8335256 [details]
support inputs entry point for the keyboard app
looks good to me, r=yurenju
Attachment #8335256 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 8•11 years ago
|
||
I'll need landing buddies for both master and v1.2, thanks.
Keywords: checkin-needed
Comment 9•11 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/f936039df67b3f86463f70681dc9e71256d74823
John should take care of the uplift as part of his regular routine.
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 5 - 11/22
Comment 10•11 years ago
|
||
Uplifted f936039df67b3f86463f70681dc9e71256d74823 to:
v1.2: 6c755778a4595586f875edb02ecc262d093c0f93
status-b2g-v1.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•