Closed Bug 940922 Opened 11 years ago Closed 7 years ago

[Flatfish] [BuildingBlock] Make date selector not fill full screen

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: gasolin, Unassigned)

References

Details

(Whiteboard: [flatfish][TCP=polish])

Attachments

(4 files, 2 obsolete files)

UI spec
(deleted), image/png
Details
date selector screenshot
(deleted), image/png
Details
pull request redirect to github
(deleted), text/x-github-pull-request
Details
patch in github
(deleted), text/x-github-pull-request
Details
Make date selector dialogs not fill full screen, have modal dialog instead
Blocks: flatfish, 935816
Whiteboard: [Flatfish only][developer+]
Depends on: 929369
Attached image UI spec (deleted) —
Assignee: nobody → gasolin
Attached image date selector screenshot (obsolete) (deleted) —
Fang, please help check if the style is correct
Attachment #8337700 - Flags: feedback?(fshih)
Attached image date selector screenshot (deleted) —
Attachment #8337700 - Attachment is obsolete: true
Attachment #8337700 - Flags: feedback?(fshih)
Attached file pull request redirect to github (deleted) —
WIP need test on phone then flag for review
Comment on attachment 8337717 [details] pull request redirect to github FYI old implementation (seems outdated) for reference
Flags: needinfo?(arnau)
Assignee: gasolin → nobody
Attached file patch in github (deleted) —
Flags: needinfo?(arnau)
Hey Fred, Paco created some time ago, as an exercise, a tablet version for all modals. UI could be wrong as we had no specs when he did that, just guessed how could that be. Please review the implementation and maybe he could evolve this PR with the attached specs. He has all modals in one PR, maybe we should split it.
Whiteboard: [Flatfish only][developer+] → [Flatfish only][developer+][TCP]
Blocks: flatfish-ux
No longer blocks: flatfish
Whiteboard: [Flatfish only][developer+][TCP] → [flatfish][TCP]
Whiteboard: [flatfish][TCP] → [flatfish][TCP=polish]
Attached file Pull request (obsolete) (deleted) —
Hi Fred, Arnau, I made a pull request base on attachment 8337717 [details], attachment 8412483 [details], and a little modification to meet the spec, could you take a look on that? thanks. Github pull request: https://github.com/mozilla-b2g/gaia/pull/22883
Assignee: nobody → shchen
Attachment #8472913 - Flags: feedback?(rnowmrch)
Attachment #8472913 - Flags: feedback?(gasolin)
Attachment #8472913 - Attachment is obsolete: true
Attachment #8472913 - Flags: feedback?(rnowmrch)
Attachment #8472913 - Flags: feedback?(gasolin)
Unassign myself since I don't have enough bandwidth on it.
Assignee: shchen → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: