Closed
Bug 941046
Opened 11 years ago
Closed 11 years ago
Add test to ensure Fitts Law works on the Back button on Windows
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: jaws, Assigned: jaws)
Details
Attachments
(1 file)
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Bug 571454 added code to specifically support clicking on the first pixel of the window when in maximized mode so that it would trigger hitting the back button on a default profile in Windows.
We should have a test that verifies this behavior exists and doesn't regress.
Pushed to tryserver: https://tbpl.mozilla.org/?tree=Try&rev=5bdfc9acf79e
Attachment #8335344 -
Flags: review?(felipc)
Assignee | ||
Comment 1•11 years ago
|
||
All green on Tryserver.
Comment 2•11 years ago
|
||
Comment on attachment 8335344 [details] [diff] [review]
backButtonTest.patch
Review of attachment 8335344 [details] [diff] [review]:
-----------------------------------------------------------------
r+, but I would suggest listening for a "popstate" event instead of waitForCondition, to make the test more deterministic and also more e10s friendly.
::: browser/base/content/test/general/browser_backButtonFitts.js
@@ +20,5 @@
> + EventUtils.synthesizeMouseAtPoint(xPixel, yPixel, {}, window);
> + var condition = function() gBrowser.selectedBrowser.contentDocument.location.href == firstLocation;
> + waitForCondition(condition,
> + () => {
> + ok(condition(), "Clicking the first pixel should have navigated back.");
no need to re-run condition, you could just have ok(true, ...) here
Attachment #8335344 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Flags: in-testsuite+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•