Closed Bug 941136 Opened 11 years ago Closed 11 years ago

getUrl not matching webdriver command getCurrentUrl

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox28 fixed, firefox29 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla29
Tracking Flags:
Tracking Status
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch
(deleted), patch
ato
: review+
Details | Diff | Splinter Review
Marionette uses "getUrl" for getting the current browser window's URL while the expected webdriver command is "getCurrentUrl". This incompatibility makes it harder to use Marionette directly without maintaining a WebDriver-to-Marionette command conversion set.
Raised https://www.w3.org/Bugs/Public/show_bug.cgi?id=24131 as its not currently in the specification
Status: NEW → ASSIGNED
QA Contact: ato
Comment on attachment 8362490 [details] [diff] [review] 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch Forgot to update the Python client. There's nothing functionally wrong with the current patch, but I'll upload a new one that covers everything in one go.
Attachment #8362490 - Flags: review?(dburns)
Uploaded new patch that also updates the Python client. new try: https://tbpl.mozilla.org/?tree=Try&rev=5c2a5766db49
Attachment #8362490 - Attachment is obsolete: true
Attachment #8362556 - Flags: review?(dburns)
Comment on attachment 8362556 [details] [diff] [review] 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch Review of attachment 8362556 [details] [diff] [review]: ----------------------------------------------------------------- r+ if you can update the with the comment ::: testing/marionette/marionette-listener.js @@ +1236,4 @@ > curFrame.location = msg.json.url; > } > > +/** Get URL of the top level browsing context. */ Can we have this multi line again
Attachment #8362556 - Flags: review?(dburns) → review+
Attachment #8362556 - Attachment is obsolete: true
Attachment #8362905 - Flags: review+
Keywords: checkin-needed
This doesn't apply on top of the other patches you requested checkin on. Please rebase and indicate the proper landing order.
Keywords: checkin-needed
Rebased patch. Please apply this first, then the updated patch from bug 941132.
Attachment #8362905 - Attachment is obsolete: true
Attachment #8363075 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/df11842197ff
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
QA Contact: ato
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: