Closed
Bug 941331
Opened 11 years ago
Closed 11 years ago
Double-tap zoom should include a margin around the tapped element
Categories
(Firefox for Metro Graveyard :: Pan and Zoom, defect)
Firefox for Metro Graveyard
Pan and Zoom
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ally
:
review+
|
Details | Diff | Splinter Review |
When zooming into a block of text, it's easier to read the text if it doesn't extend all the way to the edge of the screen, but instead has a small margin around it -- maybe 16px added to each side of the rectangle.
Updated•11 years ago
|
Blocks: metrov1backlog
Summary: Double-tap zoom should include a margin around the tapped element → Change - Double-tap zoom should include a margin around the tapped element
Whiteboard: [triage] feature=change c=tbd u=tbd p=0
Assignee | ||
Comment 1•11 years ago
|
||
Updated•11 years ago
|
No longer blocks: metrov1backlog
Summary: Change - Double-tap zoom should include a margin around the tapped element → Double-tap zoom should include a margin around the tapped element
Whiteboard: [triage] feature=change c=tbd u=tbd p=0
Comment 2•11 years ago
|
||
Just 16 pixels? I think we should be much more subtle - maybe 10% of the view width or height, whichever is smaller? It feels like we are too aggressive in our zoom in.
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #2)
> Just 16 pixels? I think we should be much more subtle - maybe 10% of the
> view width or height, whichever is smaller? It feels like we are too
> aggressive in our zoom in.
The downside of making the margin much larger is that, instead of seeing just the element you tapped, you get other elements peeeking in at the edges of the screen -- ads and navigation bars in particular.
Note that this is 16px in page coordinates, not screen coordinates. If you are zoomed in to 2x scale, then those "16px" will be 32px (1/3") on screen. On a high-dpi screen (1.8dppx), that's a margin of 58 device pixels on each side.
Comment 4•11 years ago
|
||
Comment on attachment 8335721 [details] [diff] [review]
patch
Review of attachment 8335721 [details] [diff] [review]:
-----------------------------------------------------------------
nit: Please stick the '16' in a const, maybe at the top of the file. Jimm, we can tune that margin as needed.
Attachment #8335721 -
Flags: review?(ally) → review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to :Ally Naaktgeboren from comment #4)
> nit: Please stick the '16' in a const, maybe at the top of the file.
Fixed:
https://hg.mozilla.org/integration/fx-team/rev/5c11b81a0c91
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•