Closed
Bug 941340
Opened 11 years ago
Closed 11 years ago
Avoid marionette-induced mkdir() on TmpD in content process during reftests
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: jld, Assigned: jld)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
Currently, reftests fail under content process sandboxing (bug 790923) because the Marionette listener uses FileUtils to access a file in TmpD, which unneccesarily tries to mkdir() the temporary directory; mkdir() is not on the system call whitelist, so the process is killed.
Longer-term we plan to remove open(), so the file access will have to be converted to use IPC, but for now we're just trying to get the tests to pass, and avoiding the mkdir is a workaround.
Attachment #8335653 -
Flags: review?(mdas)
Assignee | ||
Updated•11 years ago
|
Summary: Avoid mkdir() on TmpD in content process → Avoid marionette-induced mkdir() on TmpD in content process during reftests
Comment 1•11 years ago
|
||
Are we sure the TmpD directory will always be available? It seems it will on b2g devices, but can you run this through try?
Assignee | ||
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
This mkdir call is used in Marionette tests, and we'll need to test against those. I'll push the patch against try once it opens again.
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
Tried by :philor with slightly different options: https://tbpl.mozilla.org/?tree=Try&rev=3afe8abb055f
Comment 6•11 years ago
|
||
Comment on attachment 8335653 [details] [diff] [review]
bugNNNNNN-marionette-mkdir-workaround.diff
Review of attachment 8335653 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks!
Attachment #8335653 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Update commit message to make things nicer for the checkin-people; no change to diff. Carrying over r+(mdas).
Attachment #8335653 -
Attachment is obsolete: true
Attachment #8338784 -
Flags: review+
Comment 9•11 years ago
|
||
Keywords: checkin-needed
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•