Closed Bug 941340 Opened 11 years ago Closed 11 years ago

Avoid marionette-induced mkdir() on TmpD in content process during reftests

Categories

(Remote Protocol :: Marionette, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: jld, Assigned: jld)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch bugNNNNNN-marionette-mkdir-workaround.diff (obsolete) (deleted) — Splinter Review
Currently, reftests fail under content process sandboxing (bug 790923) because the Marionette listener uses FileUtils to access a file in TmpD, which unneccesarily tries to mkdir() the temporary directory; mkdir() is not on the system call whitelist, so the process is killed. Longer-term we plan to remove open(), so the file access will have to be converted to use IPC, but for now we're just trying to get the tests to pass, and avoiding the mkdir is a workaround.
Attachment #8335653 - Flags: review?(mdas)
Summary: Avoid mkdir() on TmpD in content process → Avoid marionette-induced mkdir() on TmpD in content process during reftests
Are we sure the TmpD directory will always be available? It seems it will on b2g devices, but can you run this through try?
This mkdir call is used in Marionette tests, and we'll need to test against those. I'll push the patch against try once it opens again.
Tried by :philor with slightly different options: https://tbpl.mozilla.org/?tree=Try&rev=3afe8abb055f
Comment on attachment 8335653 [details] [diff] [review] bugNNNNNN-marionette-mkdir-workaround.diff Review of attachment 8335653 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #8335653 - Flags: review?(mdas) → review+
→ b2g-inbound
Keywords: checkin-needed
Update commit message to make things nicer for the checkin-people; no change to diff. Carrying over r+(mdas).
Attachment #8335653 - Attachment is obsolete: true
Attachment #8338784 - Flags: review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: