Closed
Bug 941387
Opened 11 years ago
Closed 11 years ago
UITour: Implement the new highlight styling and animation
Categories
(Firefox :: General, defect, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(3 files, 4 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Unfocused
:
review+
MattN
:
ui-review+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
mmaslaney
:
ui-review-
|
Details |
Michael has a proposal for some different colours and possibly a change in animation.
Assignee | ||
Comment 1•11 years ago
|
||
Michael, can you give details about the colour values?
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(mmaslaney)
Comment 2•11 years ago
|
||
/* Element Highlight: */
border-radius: 40px;
background-image: -o-radial-gradient(50% 100%, rgba(0,149,220,0.25) 50%, rgba(0,149,220,0.35) 100%);
background-image: -moz-radial-gradient(50% 100%, rgba(0,149,220,0.25) 50%, rgba(0,149,220,0.35) 100%);
background-image: -webkit-radial-gradient(50% 100%, rgba(0,149,220,0.25) 50%, rgba(0,149,220,0.35) 100%);
background-image: -ms-radial-gradient(50% 100%, rgba(0,149,220,0.25) 50%, rgba(0,149,220,0.35) 100%);
background-image: radial-gradient(50% 100%, rgba(0,149,220,0.25) 50%, rgba(0,149,220,0.35) 100%);
border: 1px solid #FFFFFF;
-moz-box-shadow: 0px 0px 3px 0px rgba(0,0,0,0.50);
-webkit-box-shadow: 0px 0px 3px 0px rgba(0,0,0,0.50);
box-shadow: 0px 0px 3px 0px rgba(0,0,0,0.50);
Flags: needinfo?(mmaslaney)
Assignee | ||
Comment 3•11 years ago
|
||
Thanks mmaslaney,
The result looks a bit different than the spec (attachment 8336360 [details]) so I'm asking for your ui-review.
Attachment #8339060 -
Flags: ui-review?(mmaslaney)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8339061 -
Flags: review?(bmcbride)
Updated•11 years ago
|
Attachment #8339060 -
Attachment is patch: false
Attachment #8339060 -
Attachment mime type: text/plain → image/png
Comment 5•11 years ago
|
||
Comment on attachment 8339061 [details] [diff] [review]
v.1 CSS from comment 2
Review of attachment 8339061 [details] [diff] [review]:
-----------------------------------------------------------------
It should really be a perfect circle, except in cases like the urlbar and search bar.
Might be easiest to just specify this as part of the UITour.targets map?
Also, the colour does indeed look off.
Attachment #8339061 -
Flags: review?(bmcbride) → review-
Comment 6•11 years ago
|
||
(In reply to mmaslaney from comment #2)
> -webkit-box-shadow:
Oh really?
Comment 7•11 years ago
|
||
Haha, Sketch spits out the CSS for all Engines...
Comment 8•11 years ago
|
||
Working on the color adjustment, the vibrancy is off compared with the spec.
Comment 9•11 years ago
|
||
NEW SPEC
radial-gradient(50% 100%, rgba(0, 150, 220, 0.3) 50%, rgba(0, 150, 220, 0.5) 100%)
Color saturation might be due to the skewed circles, which will be adjusted. Either way, I went ahead and bumped up the transparency to better match the mock. If the colors seem to vibrant after the shape adjustment, We can always revert back to the previous specs.
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Blair McBride [:Unfocused] from comment #5)
> Comment on attachment 8339061 [details] [diff] [review]
> v.1 CSS from comment 2
>
> It should really be a perfect circle, except in cases like the urlbar and
> search bar.
That's bug 943765.
> Might be easiest to just specify this as part of the UITour.targets map?
>
> Also, the colour does indeed look off.
I'll update the colour with the new details from comment 9.
Assignee | ||
Comment 11•11 years ago
|
||
Include CSS change from comment 9.
Attachment #8339061 -
Attachment is obsolete: true
Attachment #8342706 -
Flags: review?(bmcbride)
Assignee | ||
Comment 12•11 years ago
|
||
This is better but still not the identical to the mockup. Good enough for now?
Attachment #8339060 -
Attachment is obsolete: true
Attachment #8339060 -
Flags: ui-review?(mmaslaney)
Attachment #8342709 -
Flags: ui-review?(mmaslaney)
Comment 13•11 years ago
|
||
Can we try bumping up the outer transparency to:
radial-gradient(50% 100%, rgba(0, 150, 220, 0.3) 50%, rgba(0, 150, 220, 0.6) 100%)
Comment 14•11 years ago
|
||
Comment on attachment 8342709 [details]
Screen shot of menu button highlight with v.1.1
radial-gradient(50% 100%, rgba(0, 149, 220, 0.4) 50%, rgba(0, 149, 220, 0.6) 100%)
Assignee | ||
Comment 15•11 years ago
|
||
[17:31:17] <MattN> …http://grab.by/sAka (bottom one)
[17:32:07] <mmaslaney> MattN: Beautiful, thanks for the tweak.
Attachment #8342706 -
Attachment is obsolete: true
Attachment #8342709 -
Attachment is obsolete: true
Attachment #8342706 -
Flags: review?(bmcbride)
Attachment #8342709 -
Flags: ui-review?(mmaslaney)
Attachment #8342779 -
Flags: ui-review+
Attachment #8342779 -
Flags: review?(bmcbride)
Updated•11 years ago
|
Attachment #8342779 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 16•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 17•11 years ago
|
||
Er, late thought: Does this still look ok on a HiDPI display?
Comment 18•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Updated•11 years ago
|
Flags: needinfo?(MattN+bmo)
Comment 19•11 years ago
|
||
Matt, would you mind providing a screen shot of the UI highlight on a darker theme? I'm going to create an alternative to the default.
Assignee | ||
Comment 20•11 years ago
|
||
(In reply to Blair McBride [:Unfocused] from comment #17)
> Er, late thought: Does this still look ok on a HiDPI display?
Yep, LGTM.
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 21•11 years ago
|
||
(In reply to mmaslaney from comment #19)
> Matt, would you mind providing a screen shot of the UI highlight on a darker
> theme? I'm going to create an alternative to the default.
Here is one on Frozen Fox. Since this change is now in Nightly, you can test other combinations/themes in your own build if you still have the preferences set from the work week.
If you would like a change, please file a new bug blocking this one since this one is already resolved.
Attachment #8346390 -
Flags: ui-review?(mmaslaney)
Updated•11 years ago
|
Attachment #8346390 -
Flags: ui-review?(mmaslaney) → ui-review-
You need to log in
before you can comment on or make changes to this bug.
Description
•