Closed
Bug 941450
Opened 11 years ago
Closed 11 years ago
Define some class of generated files in moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
We have a bunch of foo.$(OBJ_SUFFIX): some-generated-file dependencies in the tree.
They are error-prone (both in the fact that some-generated-file might just have been added as an include to another file unnoticedly, and in the fact that it breaks UNIFIED_SOURCES in subtle ways), and useless half of the time (those dependencies are generated by the compiler for incremental builds). The other half of the time, it's a clobber build, in which case we can just enforce the build order at the build system level.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8335838 -
Flags: review?(gps)
Comment 2•11 years ago
|
||
Comment on attachment 8335838 [details] [diff] [review]
Add some GENERATED_FILES to moz.build
Review of attachment 8335838 [details] [diff] [review]:
-----------------------------------------------------------------
Lovely holdover until we express codegen in moz.build.
Attachment #8335838 -
Flags: review?(gps) → review+
Comment 3•11 years ago
|
||
I pushed this to try along since its blocking my queue, but no need to wait if you don't need try:
https://tbpl.mozilla.org/?tree=Try&rev=bd61ddee653a
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 6•11 years ago
|
||
This / bug 938437 backed out for causing jetpack failures (somehow):
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ad3f19e7c0fc&jobname=xp.*debug.*jetpack
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/de482d38dc53
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed4f3c12c532
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•