Closed
Bug 941864
Opened 11 years ago
Closed 11 years ago
UITour: Allow adding an image to info panels
Categories
(Firefox :: General, defect, P4)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 29
People
(Reporter: MattN, Assigned: Unfocused)
References
Details
Need to handle HiDPI and decide on a maximum height and width.
|
Reporter | |
Updated•11 years ago
|
Flags: needinfo?(mmaslaney)
|
Assignee | |
Comment 1•11 years ago
|
||
I'm already handling this in bug 935815. And already discussed image size with mmaslaney - settled on 48x48 (96x96 in HiDPI).
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(mmaslaney)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Aaaand from the meeting notes, I see there is still some question as to the image size.
Flags: needinfo?(mmaslaney)
|
||
Comment 3•11 years ago
|
||
We totally did. Did you need me to spec out the padding or margins, or are those already set?
Flags: needinfo?(mmaslaney)
|
|
Assignee | |
Comment 4•11 years ago
|
||
I think we're good for the margins.
This is now fixed by bug 935815:
https://hg.mozilla.org/integration/fx-team/rev/be2eafebfb4d
I expect there to be a few polish fixes needed next year - just file those as followup bugs.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Target Milestone: --- → Firefox 29
You need to log in
before you can comment on or make changes to this bug.
Description
•