Closed
Bug 942035
Opened 11 years ago
Closed 11 years ago
Change the #include guard of smime.h
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.15.4
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ryan.sleevi
:
review+
|
Details | Diff | Splinter Review |
The #include guard is currently _SECMIME_H_ which clashes with that of secmime.h.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8336591 -
Flags: review?(brian)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8336591 [details] [diff] [review]
Change the #include guard of smime.h to _SMIME_H_
Review of attachment 8336591 [details] [diff] [review]:
-----------------------------------------------------------------
r+ rsleevi
Attachment #8336591 -
Flags: review?(brian) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks! Can someone please help check in this patch for me?
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> Thanks! Can someone please help check in this patch for me?
Maybe kaie? :)
Flags: needinfo?(kaie)
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(kaie)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.15.4
|
|
Assignee | |
Comment 6•11 years ago
|
||
Thanks, Kai! What is the process of getting this patch ported to mozilla-central?
|
|
||
Comment 7•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #6)
> Thanks, Kai! What is the process of getting this patch ported to
> mozilla-central?
A new beta tag of NSS needs to be produced and imported (using client.py).
Do you need it urgently, like, immediately?
If it can wait a few days - we'll have a new snapshot of NSS landed into mozilla-central during the next couple of days anyway.
|
|
Assignee | |
Comment 8•11 years ago
|
||
(In reply to comment #7)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #6)
> > Thanks, Kai! What is the process of getting this patch ported to
> > mozilla-central?
>
> A new beta tag of NSS needs to be produced and imported (using client.py).
>
> Do you need it urgently, like, immediately?
No, it's not urgent at all.
> If it can wait a few days - we'll have a new snapshot of NSS landed into
> mozilla-central during the next couple of days anyway.
That sounds perfect, thanks! Is there a bug # that I can follow?
|
|
||
Comment 9•11 years ago
|
||
Bug 898431 was used to update mozilla-inbound to a more recent snapshot of NSS (beta 4), which includes the fix for this bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•