Closed Bug 942191 Opened 11 years ago Closed 6 years ago

[Haida] Create a template for Haida & Flatfish apps

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mbudzynski, Assigned: mbudzynski)

References

Details

Attachments

(2 files)

Because Haida gesture navigation with sheets doesn't work well on tablets we need a responsive solution for different UI with the same codebase, like in attachment.
Attached file patch (deleted) —
Attachment #8336851 - Flags: review?(21)
Comment on attachment 8336851 [details]
patch

I would like to have Tim's thoughts.
Attachment #8336851 - Flags: review?(21) → review?(timdream)
We should use Yeoman to generate template :-)
http://yeoman.io/
Comment on attachment 8336851 [details]
patch

The concept itself is nice (and I agreed with the iframes as sub-page/panel approach) but I would like to see the concept app being written in a more robust way.

1) We shouldn't be re-writing |window.open|. Maybe a router function to figure out what to do each time the menu is tapped?
2) Static HTML menu, with |window.onload| will not scale when you have to write an app as small as the Settings app. The start-up time will be unacceptable.
3) Where should the localization script (l10n.js/l20n.js) kicks in?
4) Also, I am unable to try the app out on a phone because it looks like some behavior of window manager needs to be changed too? Not sure if you did it locally (out of the branch of this pull request) or there is some dev switch I need to turn on.
5) With (4), I am unable to verify if the transition is smooth in this concept demo.

I am not sure what the "review" is needed here. This app served the purpose of showcasing the possibility of iframes as sub-page/panel well, but it's not something I think it's well-engineered enough to be used as a generic haida-compatible app re-engineering starting point ("framework").

BTW would it make sense to dive into Settings app to realize the haida concept? If this app is written well and we feel it's possible to use it as the starting point of the new Settings app, I don't see any reason not to do it. I want to have people spend time on hardening Settings app on v1.4 cycle.
Attachment #8336851 - Flags: review?(timdream) → feedback+
There's a shared/js/screen_layout.js do the trick of detecting screen size 
https://github.com/mozilla-b2g/gaia/blob/master/shared/js/screen_layout.js

You may want to reuse it or patch it to suit your needs.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: