Closed Bug 942546 Opened 11 years ago Closed 11 years ago

Add to home screen: use different labels for button and header

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: flod, Assigned: flod)

References

Details

(Keywords: late-l10n)

Attachments

(2 files)

Pull request for master branch (add a new separate entity)
(deleted), text/x-github-pull-request
kaze
: review+
Details
PR for 1.2 with fallback to existing string
(deleted), text/x-github-pull-request
kaze
: review+
Pike
: feedback+
Details
See bug 929560 for more details: basically the same label is used for a button, with a lot of space available and small font, and for the next header, resulting in truncation for most locales. As Matej suggested in bug 929560 comment 7, the header could just use "Add link".
Pull request for master adding a new entity to use in the header.
Attachment #8337363 - Flags: review?(dale)
Attachment #8337363 - Flags: review?(dale)
Component: Gaia::Browser → Gaia::Homescreen
Attachment #8337363 - Flags: review?(21)
I tested the patch locally with Italian and it works as expected. One thing I don't understand about this: I use these instructions to flash Gaia. https://l10n.etherpad.mozilla.org/gaia-multilocale When I do, new strings (in this case add-to-home-screen-header) are stripped from the en-US properties file. How can I avoid it?
Attachment #8337364 - Flags: review?(21)
Attachment #8337364 - Flags: feedback?(l10n)
Blocks: 940105, 940077, 940055, 929646, 894015, 929577, 929549, 892689, 830687
blocking-b2g: --- → koi?
Assignee: nobody → francesco.lodolo
Comment on attachment 8337363 [details] Pull request for master branch (add a new separate entity) Let's try with Kaze since Vivien is not going to review this anytime soon.
Attachment #8337363 - Flags: review?(21) → review?(kaze)
Attachment #8337364 - Flags: review?(21) → review?(kaze)
Attachment #8337363 - Flags: review?(kaze) → review+
Attachment #8337364 - Flags: review?(kaze) → review+
FTR, that’s yet another bug that is caused by the common (too large) header font-size, see bug 908300.
Depends on: 908300
Thanks Kaze, I'll need someone to land this on master, while this bug get evaluated for koi. Not sure if setting the checkin-needed could create confusion with the approved patches.
Let's try the checkin-needed for the master patch.
Keywords: checkin-needed
Leaving the bug open until we get a decision for koi.
Adding late-l10n as this is adding more l10n work. This also allows us to fix bugs, and the fallback in en-US makes us pick up the localized string as is, so practically, this isn't adding a non-localized string. Sounds koi-worthy to me.
Keywords: late-l10n
Attachment #8337364 - Flags: feedback?(l10n) → feedback+
Moving to 1.3? Rather late for 1.2.
blocking-b2g: koi? → 1.3?
(In reply to Preeti Raghunath(:Preeti) from comment #10) > Moving to 1.3? Rather late for 1.2. Can you please check again? 1.3 has already been fixed (so it's not 1.3? for sure), we have a patch for 1.2 with automatic fallbacks to the existing strings. If in doubt, please take a look at the amount of depending bugs.
blocking-b2g: 1.3? → koi?
(In reply to Francesco Lodolo [:flod] from comment #11) > (In reply to Preeti Raghunath(:Preeti) from comment #10) > > Moving to 1.3? Rather late for 1.2. > > Can you please check again? 1.3 has already been fixed (so it's not 1.3? for > sure), we have a patch for 1.2 with automatic fallbacks to the existing > strings. If in doubt, please take a look at the amount of depending bugs. We did. We don't think this is a blocker for release - I wouldn't be surprised if this problem has been present in 1.1.
blocking-b2g: koi? → 1.3?
Marking FIXED then.
Status: NEW → RESOLVED
blocking-b2g: 1.3? → ---
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: