Closed
Bug 942744
Opened 11 years ago
Closed 11 years ago
[Bluetooth] Stop discovering before connecting
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: echou, Assigned: echou)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jj.evelyn
:
review+
|
Details | Diff | Splinter Review |
Bug 873352 has the same idea as this one. Discovery is a heavy operation which would increase the failure rate of pairing or establishing a new profile level connection. Therefore we should do stopDiscovery() every time before we call pair or connect.
Recently I found that 'restore connection' was usually not successful, and the main reason was that bluedroid(bluetooth backend which will be used after FxOS v1.3) would report that RFCOMM connection couldn't be established. Once I tried to put 'stopDiscovery' in doConnect() before calling defaultAdapter.connect, everything went well. So I'd like to raise this issue again otherwise connection error may happen too often.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → echou
|
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8337627 -
Flags: review?(arthur.chen)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8337627 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14004
* Reset reviewer to Evelyn after talked to Arthur.
Attachment #8337627 -
Flags: review?(arthur.chen) → review?(ehung)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8337627 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14004
looks good to me. Thanks!
Attachment #8337627 -
Flags: review?(ehung) → review+
|
|
||
Comment 4•11 years ago
|
||
merged into gaia master: https://github.com/mozilla-b2g/gaia/commit/e64c724140bbcd582a5ec5bbe5fd5bf253a444ec
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•