Closed Bug 942879 Opened 11 years ago Closed 10 years ago

Adding panel from promo banner

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: ibarlow, Assigned: Margaret)

References

Details

Attachments

(1 file)

Let users create new lists from the home screen Snippet. Designs will be posted shortly.
Attached image Mockup of snippet (deleted) —
This is what the snippet should look like. Image: Firefox logo Text: Personalize your Home page with lists and feeds! <link>Try it out</link> Action: Launch list chooser popup
We'll need to implement the list settings screen before this will be useful, but we might as well start thinking about how we'll implement it. Right now we don't support links in the home banner, but instead have a click handler on the whole banner, so we'd need to make some changes to the banner to support this. Also, if we just use the Home.banner API to implement this, we need to make sure there's some API call we can make from JS to open the correct settings screen. Do we support launching intents from JS? Could we use this to launch some PreferenceActivity?
Flags: needinfo?(wjohnston)
(In reply to :Margaret Leibovic from comment #2) > Right now we don't support links in the home banner, but instead have a > click handler on the whole banner, so we'd need to make some changes to the > banner to support this. There is just one link inside the text. Why not just make it look like there is a link and when people try to tap on it the click handler for the banner just kicks in?
(In reply to :Margaret Leibovic from comment #2) > Do we support launching intents from JS? Could we use this to launch > some PreferenceActivity? Vaguely! We have "Intent:Open" messages. Notice almost all those parameters are options. You should be able to find something that does what you want. See: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#714
Flags: needinfo?(wjohnston)
Let's fix bug 942878 first, since that will add the dialog that we'll want to open from this promo banner.
Depends on: 942878
Summary: Adding lists from Snippet → Adding panel from promo banner
Priority: -- → P1
(In reply to :Margaret Leibovic from comment #5) > Let's fix bug 942878 first, since that will add the dialog that we'll want > to open from this promo banner. Just a quick note: we should only show this banner if we the user has installed add-ons with panels before.
Do we only want to show this banner if there are registered panels that haven't been installed yet? To implement this, we'll want to use the Home.banner API, so we could just have logic to do this in JS once a panel is registered, but currently JS doesn't know about whether or not a panel is installed. Doing this in JS also means we'll need to have some message we can send to Java to launch the picker dialog, but that seems fine.
I'm experimenting with this as part of an add-on to use for user testing, but we can integrate those changes as a patch once I'm done.
Assignee: nobody → margaret.leibovic
Depends on: 982461
Priority: P1 → P2
Priority: P2 → P3
We're getting rid of the panel picker in it's current incarnation. To promote panels in the banner, we can just use snippets to direct users to a featured list on AMO.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: