Closed Bug 942955 Opened 11 years ago Closed 11 years ago

maybeSetFrameIsCritical is unused after activity window refactor

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Keywords: perf, Whiteboard: [c= p=1 s= u=])

Attachments

(1 file)

Alive - do you think we need to set the mozapptype='critical' attribute somewhere? Seems this would also be a good candidate for an integration test.
Flags: needinfo?(alive)
Kevin - thanks for point out. The whole Window Manager is going to be removed in bug 907013. PR is https://github.com/mozilla-b2g/gaia/pull/13797 Also maybeSetFrameIsCritical now is living in browser_frame.js. I'm curious about how could integration test interact with OOM test?
Depends on: app-window-manager
Flags: needinfo?(alive)
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/browser_frame.js#L82(In reply to Alive Kuo [:alive][NEEDINFO] from comment #2) > Also maybeSetFrameIsCritical now is living in browser_frame.js.
Hi Alive - I see that the functionality now in browser_frame. I think we should remove the unused code for now.
Attachment #8338191 - Flags: review?(alive)
Attachment #8338191 - Flags: review?(alive) → review+
Assignee: nobody → kgrandon
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: perf
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Resolution: --- → FIXED
Whiteboard: [c= p=1 s= u=]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: