Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Reporter
	Description • 11 years ago

We don't really support non-UTF-8 system encodings on *nix. In order to get rid of nsIPlatformCharset, we should get rid of nsPluginTag::EnsureMembersAreUTF8(), which, AFAICT, only has effect on
 1) OS/2
 2) *nix systems with a non-UTF-8 system encoding configuration.

	Georg Fritzsche [:gfritzsche]
	Comment 1 • 11 years ago

Do we know what *nix platforms would be affected here?

	Benjamin Smedberg
	Comment 2 • 11 years ago

This function at least needs to ensure that the strings we get in from plugins are in fact UTF8, and sanitize them if they aren't. We have definitely gotten non-UTF8 strings from Java in the not so distant past, and they were causing aborts.

	Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Reporter
	Comment 3 • 11 years ago

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> This function at least needs to ensure that the strings we get in from
> plugins are in fact UTF8, and sanitize them if they aren't. We have
> definitely gotten non-UTF8 strings from Java in the not so distant past, and
> they were causing aborts.

OK. Morphing the bug summary accordingly. It's probably enough for crash avoidance to check if the strings are valid UTF-8 and, if they are not, performing a conversion from windows-1252 to UTF-8 to get *some* strings that are valid UTF-8.

(In reply to Georg Fritzsche [:gfritzsche] from comment #1)
> Do we know what *nix platforms would be affected here?

Not sure. Presumably fringe/legacy configurations of all of them.

	Makoto Kato [:m_kato] Assignee
	Comment 4 • 7 years ago

Since we only support Flash, so we can remove nsIPlatformCharset.  Flash is English version only on Linux.

	Benjamin Smedberg
	Comment 5 • 7 years ago

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.

	Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Reporter
	Comment 6 • 7 years ago

Still there:
https://dxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginTags.cpp#477

	Benjamin Smedberg
	Comment 7 • 7 years ago

The plugins team is never going to work on this bug. Is it really worth keeping it open?

	Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Reporter
	Comment 8 • 7 years ago

(In reply to Benjamin Smedberg [:bsmedberg] from comment #7)
> The plugins team is never going to work on this bug. Is it really worth
> keeping it open?

Yes, this tracks getting rid of nsIPlatformCharset, so it's worth keeping open until this nsIPlatformCharset use has been removed.

	Makoto Kato [:m_kato] Assignee
	Comment 10 • 7 years ago

Comment on attachment 8884706 [details] [diff] [review]
Remove unused nsIPlatfromCharset

After landing bug 1261841, we don't use nsIPlatformCharset on nsPluginTags.  So we should remove unused header.

	Pulsebot
	Comment 11 • 7 years ago

Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4eb026e67d
Remove unused nsIPlatfromCharset. r=emk

	Carsten Book [:Tomcat]
	Comment 12 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ac4eb026e67d