Paul Silaghi, QA [:pauly] Reporter
	Description • 11 years ago

STR:
1. Open http://benjamin.smedbergs.us/tests/ctptests/javaflash-together.html
2. 'Allow Now' Flash
3. Open the CTP doorhanger

AR: Flash is 'Allow and remember'

	Paul Silaghi, QA [:pauly] Reporter
	Comment 1 • 11 years ago

'Allow now' Flash:
after bug 926605 landed, Flash is 'Block plugin'
after bug 932786 landed, Flash is 'Allow and remember'

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 2 • 11 years ago

How is this verified as fixed on 26 in https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c13 but now no longer working as expected?  Did something else change between landing bug 932786 and now?  Benjamin or David - is this a major issue or is it like in https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c2 where it only affects a small subsection of users?

	Paul Silaghi, QA [:pauly] Reporter
	Comment 3 • 11 years ago

(In reply to lsblakk@mozilla.com [:lsblakk] from comment #2)
> How is this verified as fixed on 26 in
> https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c13 but now no longer
> working as expected? 
This is a different issue, even if the titles look closer.

	(Away)
	Comment 4 • 11 years ago

(In reply to lsblakk@mozilla.com [:lsblakk] from comment #2)
> How is this verified as fixed on 26 in
> https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c13 but now no longer
> working as expected?  Did something else change between landing bug 932786
> and now?  Benjamin or David - is this a major issue or is it like in
> https://bugzilla.mozilla.org/show_bug.cgi?id=932786#c2 where it only affects
> a small subsection of users?

I don't have any experience with CtP. John, is this something you can answer?

	John Schoenick [:johns]
	Comment 5 • 11 years ago

The multi-item popup is a different case than the single-item popup that is bugged. If it's not difficult, it would be a good idea to add this to the ctp browserchrome tests, however.

Seeing as it is a broken confusing UI, and probably not too complicated to fix, I'm guessing we should track

	Benjamin Smedberg
	Comment 6 • 11 years ago

This is a very minor piece of UI, and not something that I would track at all. It still shows the correct enabled state, it just doesn't show you whether it's "for now" or "always" correctly.

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 7 • 11 years ago

The permission that is stored is indeed correct - this is just the display in the doorhanger being incorrect until you reload/reopen the page.
Will probably finish up later this week.

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 8 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=2220d0f76274

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 9 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d784aa614a9

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/3d784aa614a9

	Paul Silaghi, QA [:pauly] Reporter
	Comment 11 • 11 years ago

Verified fixed 29.0a1 (2013-12-11) Win 7 x64