Closed
Bug 943407
Opened 11 years ago
Closed 11 years ago
Port GTK2 to GTK3 - build failure - nsWindow::StartRemoteDrawing()
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: stransky, Assigned: stransky)
References
Details
(Keywords: regression, Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #627699 +++ nsWindow.cpp:5998 error: no matching function for call to ‘nsWindow::GetThebesSurface()’ TemporaryRef<DrawTarget> nsWindow::StartRemoteDrawing() { gfxASurface *surf = GetThebesSurface(); if (!surf) { return nullptr; }
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Whiteboard: [leave open for remaining patches][check linux try build before requesting checkin]
Assignee | ||
Comment 1•11 years ago
|
||
The remote Drawing is not used now but it fails to build in gtk3. The missing cairo_copy_clip_rectangle_list() causes crash on start.
Assignee: nobody → stransky
Attachment #8340375 -
Flags: review?(karlt)
Updated•11 years ago
|
Blocks: 882447
Keywords: regression
Comment 2•11 years ago
|
||
Comment on attachment 8340375 [details] [diff] [review] patch >+ // TODO Gtk3 Please make this "TODO GTK3", so we need only search for one string to find remaining tasks.
Attachment #8340375 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Fixed, Thanks!
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Updated•11 years ago
|
Attachment #8340375 -
Attachment is obsolete: true
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5bc60ae5c0a
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e5bc60ae5c0a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•