Closed Bug 943407 Opened 11 years ago Closed 11 years ago

Port GTK2 to GTK3 - build failure - nsWindow::StartRemoteDrawing()

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: stransky, Assigned: stransky)

References

Details

(Keywords: regression, Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #627699 +++

nsWindow.cpp:5998 error: no matching function for call to ‘nsWindow::GetThebesSurface()’                                                                                                                    
TemporaryRef<DrawTarget>
nsWindow::StartRemoteDrawing()
{   
  gfxASurface *surf = GetThebesSurface();
  if (!surf) {
    return nullptr;
  }
Blocks: gtk3
No longer blocks: 513159, wayland, 711711, 738937, 813578, 882036, 723754, 884634
Whiteboard: [leave open for remaining patches][check linux try build before requesting checkin]
Attached patch patch (obsolete) (deleted) — Splinter Review
The remote Drawing is not used now but it fails to build in gtk3. The missing cairo_copy_clip_rectangle_list() causes crash on start.
Assignee: nobody → stransky
Attachment #8340375 - Flags: review?(karlt)
Blocks: 882447
Keywords: regression
Comment on attachment 8340375 [details] [diff] [review]
patch

>+  // TODO Gtk3

Please make this "TODO GTK3", so we need only search for one string to find remaining tasks.
Attachment #8340375 - Flags: review?(karlt) → review+
Attached patch patch for check-in (deleted) — Splinter Review
Fixed, Thanks!
Attachment #8340375 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e5bc60ae5c0a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Blocks: 1034064
No longer blocks: 1034064
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: