Closed
Bug 943542
Opened 11 years ago
Closed 11 years ago
Defect - this._onClickCoords is not a function in SelectionHandler.js
Categories
(Firefox for Metro Graveyard :: Input, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: spohl, Assigned: spohl)
References
Details
(Whiteboard: [block28] feature=defect c=tbd u=tbd p=1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
While debugging I saw this in the console:
System JS : ERROR chrome://browser/content/contenthandlers/SelectionHandler.js:550 - TypeError: this._onClickCoords is not a function
The last update to the "part 1" patch in bug 925467 changed the function name from _onClickCoords to onClickCoords, but the patch in bug 925457 still relied on the old function name with underscore.
|
Assignee | |
Comment 1•11 years ago
|
||
Adding back the underscore. I believe it was removed by accident.
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Attachment #8338748 -
Flags: review?(jmathies)
|
||
Comment 2•11 years ago
|
||
(In reply to Stephen Pohl [:spohl] from comment #1)
> Created attachment 8338748 [details] [diff] [review]
> Patch
>
> Adding back the underscore. I believe it was removed by accident.
since it's a public api, can you do the reverse? (Track down the callers and update them.)
|
||
Updated•11 years ago
|
Blocks: metrov1it20
Priority: -- → P2
QA Contact: jbecerra
Summary: [block28] this._onClickCoords is not a function in SelectionHandler.js → Defect - this._onClickCoords is not a function in SelectionHandler.js
Whiteboard: [block28] feature=defect c=tbd u=tbd p=0
|
|
Assignee | |
Comment 3•11 years ago
|
||
Sure! There was only one caller (added in bug 925457).
Attachment #8338748 -
Attachment is obsolete: true
Attachment #8338748 -
Flags: review?(jmathies)
Attachment #8338763 -
Flags: review?(jmathies)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [block28] feature=defect c=tbd u=tbd p=0 → [block28] feature=defect c=tbd u=tbd p=1
|
|
||
Updated•11 years ago
|
Attachment #8338763 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•