Closed
Bug 943743
Opened 11 years ago
Closed 11 years ago
Remove NATIVE_THEME_SUPPORT
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
widget/gtk/Makefile.in reads:
NATIVE_THEME_SUPPORT = 1
ifdef NATIVE_THEME_SUPPORT
DEFINES += -DNATIVE_THEME_SUPPORT
endif
IOW, we're always building with that defined. Might as well just remove it and the corresponding #ifdefs.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8339064 -
Flags: review?(karlt)
|
|
Assignee | |
Comment 2•11 years ago
|
||
(Moreover building without NATIVE_THEME_SUPPORT turns many tests orange. I know because I ended up disabling it while working on bug 874266, and it broke many things)
|
||
Updated•11 years ago
|
Attachment #8339064 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•