Closed
Bug 943809
Opened 11 years ago
Closed 9 years ago
[bluedroid] HID prototype
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1223729
People
(Reporter: shawnjohnjr, Assigned: shawnjohnjr)
References
Details
Attachments
(6 files, 9 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
arthurcc
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
[bluedroid] HID prototype
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8339887 -
Flags: review?(echou)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8339889 -
Flags: review?(echou)
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8339889 [details] [diff] [review] Bug943809-Part2: BluetoothHidManager for bluedroid During integration with Setting, I found I missed event notification part.
Attachment #8339889 -
Attachment is obsolete: true
Attachment #8339889 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Attachment #8339887 -
Attachment is obsolete: true
Attachment #8339887 -
Flags: review?(echou)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8340911 -
Flags: review?(echou)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #8340912 -
Flags: review?(echou)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8340913 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Assignee | ||
Updated•11 years ago
|
Attachment #8340911 -
Attachment description: Bug943809-Part1: Relocate files → Bug943809 - Part1: Relocate files
Assignee | ||
Updated•11 years ago
|
Attachment #8340912 -
Attachment description: Bug943809-Part2: BluetoothHidManager for bluedroid → Bug943809 - Part2: BluetoothHidManager for bluedroid
Assignee | ||
Updated•11 years ago
|
Attachment #8340912 -
Attachment description: Bug943809 - Part2: BluetoothHidManager for bluedroid → Bug 943809 - Part2: BluetoothHidManager for bluedroid
Assignee | ||
Updated•11 years ago
|
Attachment #8340911 -
Attachment description: Bug943809 - Part1: Relocate files → Bug 943809 - Part1: Relocate files
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #8340944 -
Flags: feedback?(arthur.chen)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → shuang
Assignee | ||
Comment 8•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8340949 -
Flags: review?(echou)
Comment 9•11 years ago
|
||
Comment on attachment 8340944 [details] [diff] [review] hid-gaia.patch Shawn, thanks for the first gaia patch! :) Please check my comment. And we also need to do some modifications on system/js/bluetooth.js.
Attachment #8340944 -
Flags: feedback?(arthur.chen)
Assignee | ||
Updated•11 years ago
|
Attachment #8340944 -
Attachment is obsolete: true
Assignee | ||
Comment 10•11 years ago
|
||
Attachment #8340997 -
Flags: feedback?(arthur.chen)
Assignee | ||
Updated•11 years ago
|
Attachment #8340911 -
Attachment is obsolete: true
Attachment #8340911 -
Flags: review?(echou)
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #8341005 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Attachment #8340912 -
Attachment is obsolete: true
Attachment #8340912 -
Flags: review?(echou)
Assignee | ||
Comment 12•11 years ago
|
||
Attachment #8341006 -
Flags: review?(echou)
Comment 13•11 years ago
|
||
Comment on attachment 8340997 [details] [diff] [review] hid-gaia-v2.patch Review of attachment 8340997 [details] [diff] [review]: ----------------------------------------------------------------- ::: apps/system/js/bluetooth.js @@ +10,4 @@ > OPP: 'opp', // Object Push Profile > A2DP: 'a2dp', // A2DP status > SCO: 'sco' // Synchronous Connection-Oriented > + HID: 'hid' // Synchronous Connection-Oriented Please add the full name of "HID". @@ +181,4 @@ > self.updateConnected(); > }; > > + adapter.onhfpstatuschanged = function bt_hidStatusChanged(evt) { Should be "onhidstatuschanged".
Attachment #8340997 -
Flags: feedback?(arthur.chen)
Assignee | ||
Updated•11 years ago
|
Attachment #8340997 -
Attachment is obsolete: true
Assignee | ||
Comment 14•11 years ago
|
||
Assignee | ||
Comment 15•11 years ago
|
||
Attachment #8341526 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Attachment #8341525 -
Flags: review?(arthur.chen)
Comment 16•11 years ago
|
||
Comment on attachment 8341525 [details] [diff] [review] hid-gaia-v3.patch Review of attachment 8341525 [details] [diff] [review]: ----------------------------------------------------------------- r=me, thank you for the effort!
Attachment #8341525 -
Flags: review?(arthur.chen) → review+
Comment 17•11 years ago
|
||
Comment on attachment 8341005 [details] [diff] [review] Bug 943809 - Part1: Reallocate Hid files Review of attachment 8341005 [details] [diff] [review]: ----------------------------------------------------------------- Please remember to touch CLOBBER in order to trigger a clean build on tinderbox.
Updated•11 years ago
|
Attachment #8341005 -
Flags: review?(echou) → review+
Comment 18•11 years ago
|
||
(In reply to Eric Chou [:ericchou] [:echou] (OOO 12/12 ~ 12/15) from comment #17) > Comment on attachment 8341005 [details] [diff] [review] > Bug 943809 - Part1: Reallocate Hid files > > Review of attachment 8341005 [details] [diff] [review]: > ----------------------------------------------------------------- > > Please remember to touch CLOBBER in order to trigger a clean build on > tinderbox. Oh, I saw the 5th patch. Please forget what I just said in comment 17. :)
Updated•11 years ago
|
Attachment #8341526 -
Flags: review?(echou) → review+
Assignee | ||
Comment 19•11 years ago
|
||
Comment on attachment 8341005 [details] [diff] [review] Bug 943809 - Part1: Reallocate Hid files We shall use 'hg mv' instead of deleting files.
Attachment #8341005 -
Attachment is obsolete: true
Attachment #8341005 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Attachment #8341006 -
Attachment is obsolete: true
Attachment #8341006 -
Flags: review?(echou)
Assignee | ||
Comment 20•11 years ago
|
||
Attachment #8348621 -
Flags: review?(echou)
Assignee | ||
Comment 21•11 years ago
|
||
Attachment #8348622 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Attachment #8348621 -
Attachment is obsolete: true
Attachment #8348621 -
Flags: review?(echou)
Assignee | ||
Comment 22•11 years ago
|
||
Attachment #8348630 -
Flags: review?(echou)
Assignee | ||
Comment 23•11 years ago
|
||
I've tried this patch on Nexus-4 with Apple Wireless keyboard and Logitech keyboard, which is based on bluedroid stack.
Assignee | ||
Comment 24•11 years ago
|
||
If you have problem with reconnect, see also bug 953019. Some HID keyboards don't support connection initiated from phone.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Attachment #8340913 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Attachment #8340949 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Attachment #8348622 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Attachment #8348630 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
Assignee: shuang → joliu
Assignee | ||
Comment 25•11 years ago
|
||
Pass HID feature to Jocelyn :)
Assignee | ||
Updated•10 years ago
|
Assignee: joliu → shuang
Assignee | ||
Comment 26•10 years ago
|
||
Move on :)
Assignee | ||
Comment 27•10 years ago
|
||
We're going to have major refactoring on Bluetooth module, especially removing BT HAL dependent data type. So, after that was done, we will work on rebase patches.
Assignee | ||
Updated•10 years ago
|
Attachment #8341526 -
Flags: review+
Assignee | ||
Comment 28•10 years ago
|
||
Because we changed the way to access bluedroid through bluetoothd. These patch need to be re-written.
Assignee | ||
Comment 29•9 years ago
|
||
Hey cyu, If you are interested in this bug, here you go!
Flags: needinfo?(cyu)
Updated•9 years ago
|
Blocks: TV_FxOS2.5
Updated•9 years ago
|
No longer blocks: TV_FxOS2.5
Updated•9 years ago
|
Comment 30•9 years ago
|
||
Since we moved to Bluetooth APIv2, The gaia patch need to be re-written as well
Comment 31•9 years ago
|
||
Remove NI flag since this is currently not on my plate.
Flags: needinfo?(cyu)
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Comment 33•9 years ago
|
||
Bug 1223729 has covered HID prototype.
You need to log in
before you can comment on or make changes to this bug.
Description
•