Closed
Bug 943917
Opened 11 years ago
Closed 11 years ago
[Australis] When closing a tab using the close button, the hover state of the closing briefly appears
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: phlsa, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [Australis:P4])
Attachments
(1 file)
|
(deleted),
image/png
|
Details |
undesired hover state when closing a tab
This only happens for one animation frame or two. It can be perceived as flickering.
|
||
Updated•11 years ago
|
Blocks: australis-merge
OS: Mac OS X → All
Whiteboard: [Australis:P4][good-first-bug][lang=css][mentor=mconley]
|
|
||
Comment 1•11 years ago
|
||
What's happening is that even though the tabbrowser-tab's visibility is set to hidden when closing the tab[1], the tab-background has its visibility set to visible which makes the tab background stroke appear on hover.
I think the solution here is to make our CSS in browser/themes/shared/tabs.inc.css that draws the background stroke[3] to not do this if the fadein attribute does not exist (which indicates that the tab is closing).
[1]: https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#114
[2]: https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#122
[3]: https://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#226
|
||
Comment 2•11 years ago
|
||
(In reply to Mike Conley (:mconley) from comment #1)
> What's happening is that even though the tabbrowser-tab's visibility is set
> to hidden when closing the tab[1], the tab-background has its visibility set
> to visible which makes the tab background stroke appear on hover.
>
> I think the solution here is to make our CSS in
> browser/themes/shared/tabs.inc.css that draws the background stroke[3] to
> not do this if the fadein attribute does not exist (which indicates that the
> tab is closing).
We should fix the code that introduced this bug, in browser/base/content/browser.css.
Blocks: 940262
Keywords: regression
|
|
||
Comment 3•11 years ago
|
||
This is basically the same as bug 944136.
Depends on: 944136
Whiteboard: [Australis:P4][good-first-bug][lang=css][mentor=mconley] → [Australis:P4]
|
Reporter | |
Comment 4•11 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #3)
> This is basically the same as bug 944136.
Is it? Will fixing the performance regression in bug 944136 automatically also fix the visual issue?
|
|
||
Comment 5•11 years ago
|
||
(In reply to Philipp Sackl [:phlsa] from comment #4)
> (In reply to Dão Gottwald [:dao] from comment #3)
> > This is basically the same as bug 944136.
>
> Is it? Will fixing the performance regression in bug 944136 automatically
> also fix the visual issue?
Yes, it should.
|
Assignee | |
Comment 6•11 years ago
|
||
Yes, this will indeed be fixed by bug 944136.
|
|
Assignee | |
Comment 7•11 years ago
|
||
Fixed by bug 944136.
Status: NEW → RESOLVED
Closed: 11 years ago
Hardware: x86 → All
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Assignee: nobody → ttaubert
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•