Closed Bug 944250 Opened 11 years ago Closed 11 years ago

[Fugu] [B2G] emergencyCallsOnly is false even there is no sim card inserted

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:fugu+)

RESOLVED FIXED
1.3 Sprint 6 - 12/6
blocking-b2g fugu+

People

(Reporter: edgar, Assigned: edgar)

References

Details

(Whiteboard: [Fugu] [v1.2f-uplift-needed])

Attachments

(1 file)

|mozMobileConnection[x].voice.emergencyCallsOnly| should be true when voice is not registered to network. But in fugu, even there is no sim card inserted, the emergencyCallsOnly is still false.
After checking the code, the root cause is |ro.moz.ril.emergency_by_default| does not be set correct in fugu build. After set |ro.moz.ril.emergency_by_default| to true, the |emergencyCallsOnly| attribute is updated as we expected. However, the |ro.moz.ril.emergency_by_default| is for Akami [2][3], I think we could remove this RILQUIRK constant[1] since we are no longer supporting Akami any more.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js#82
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=714973#c8
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=714973#c10
Attached patch Patch, v1 (deleted) — Splinter Review
Attachment #8339841 - Flags: review?(htsai)
Comment on attachment 8339841 [details] [diff] [review]
Patch, v1

Review of attachment 8339841 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, thank you.
Attachment #8339841 - Flags: review?(htsai) → review+
Try server: https://tbpl.mozilla.org/?tree=Try&rev=93f7f95a1925
https://hg.mozilla.org/integration/b2g-inbound/rev/0a38dc2f9f29
blocking-b2g: --- → 1.3?
Target Milestone: --- → 1.3 Sprint 6 - 12/6
blocking-b2g: 1.3? → fugu+
https://hg.mozilla.org/mozilla-central/rev/0a38dc2f9f29
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Fugu] [v1.2f-uplift-needed]
Blocks: 943227
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: