Closed
Bug 944295
Opened 11 years ago
Closed 11 years ago
[Keyboard][V1.2] Installation UI still shown after perf off the OOP
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 fixed)
People
(Reporter: whsu, Assigned: timdream)
Details
(Whiteboard: [FT:System-Platform],[3rd-party-keyboard])
Attachments
(1 file)
* Description:
This bug relates to bug 941885.
We found that the installation UI still shown after perf off the OOP of keyboard
* Reproduction steps:
1. Perf off the OOP of keyboard
2. Using App manager to install a third party keyboard.
* Expected result:
User cannot install the third party keyboard and no installation UI displayed.
* Actual result:
The installation UI still shown
* Test Build:
- Gaia: 92cd11ea023dd6598d82d859ae3c945ff6589ce6
- Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/14e91ab12441
- BuildID 20131127004001
- Version 26.0
Reporter | ||
Updated•11 years ago
|
Whiteboard: [FT:System-Platform],[3rd-party-keyboard]
Comment 1•11 years ago
|
||
This blocks doing a full pref off of the 3rd party keyboard feature on 1.2.
blocking-b2g: --- → koi?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → timdream
Assignee | ||
Updated•11 years ago
|
Attachment #8340216 -
Flags: review?(gchen)
Comment 3•11 years ago
|
||
Comment on attachment 8340216 [details]
mozilla-b2g:master PR#14201
r=me, thanks.
Attachment #8340216 -
Flags: review?(gchen) → review+
Assignee | ||
Comment 4•11 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/00b3f8e781ce8d721c50ea7015010b67dba69c2a
I fixed the unit tests.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/31fb2f463359
Gaia UI test had failed before my patch :-/
Assignee | ||
Comment 6•11 years ago
|
||
Reporter | ||
Comment 7•11 years ago
|
||
Hi, Tim,
Thanks for your help.
I will verify it later.
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Reporter | ||
Comment 8•11 years ago
|
||
Hi, Tim,
Thanks for your prompt help.
Verified it on M-C build. It works as expected.
The V1.2 build still needs this patch. We could uplift it.
Many thanks.
* Test Build:
- Gaia: 1dd0e5c644b4c677a4e8fa02e50d52136db489d9
- Gecko: http://hg.mozilla.org/mozilla-central/rev/725c36b5de1a
- BuildID 20131205040201
- Version 28.0a1
Status: RESOLVED → VERIFIED
Comment 9•11 years ago
|
||
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1.2
git cherry-pick -x -m1 00b3f8e781ce8d721c50ea7015010b67dba69c2a
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(timdream)
Assignee | ||
Comment 10•11 years ago
|
||
v1.2: d8e179f0014c7e8c5855bed6484340e94dc94132
status-b2g-v1.2:
--- → fixed
Flags: needinfo?(timdream)
Reporter | ||
Comment 11•11 years ago
|
||
Also, I have tested the patch on V1.2 branch.
Many thanks!
* The tested build:
- Gaia: 4f53ba8b3628ac311253fc28dfdf66e7ba6832de
- Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/129ad3c335a5
- BuildID 20131217004001
- Version 26.0
You need to log in
before you can comment on or make changes to this bug.
Description
•