Closed
Bug 944438
Opened 11 years ago
Closed 11 years ago
Get rid of InstallSignalHandlersMutex
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: iacobcatalin, Assigned: iacobcatalin)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=819839#c28
Luke Wagner says:
"
Initially EnsureAsmJSSignalHandlers was called lazily, so you could race if two workers happened to compile asm.js at the same time. Now it is called in JSRuntime::init, which I think we can assume happens-before other JSRuntime create. Thus, I'd be fine if you replaced all that junk with a simple
static bool sHandlersInstalled = false;
which was tested/set where lock.handlersInstalled()/lock.setHandlersInstalled() are called now.
"
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → iacobcatalin
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8340035 -
Flags: review?(luke)
Comment 2•11 years ago
|
||
Comment on attachment 8340035 [details] [diff] [review]
get-rid-of-InstallSignalHandlersMutex.patch
Thanks!
Attachment #8340035 -
Flags: review?(luke) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 3•11 years ago
|
||
Keywords: checkin-needed
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•