Closed
Bug 944613
Opened 11 years ago
Closed 11 years ago
[Settings] The 'SIM manager' should be 'SIM Manager'
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: gweng, Assigned: waynux)
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
Other entries are all follows the pattern:
Foo Bar
So this should be fixed. I think this should be a good first bug, but maybe it's too obvious.
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [g
|
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [g → [good first bug]
|
||
Comment 1•11 years ago
|
||
Hi,
could you say me where is located this line to be fixed to make a pull request with the fix?
Regards,
Gio
|
||
Comment 2•11 years ago
|
||
Hi, thanks for concerning fix it. Please open settings app's code and search the string.
Generally there are 2 places need to be change,
* one is from settings/index.html,
* another is the locales/settings.en-US.properties
the other locales will be translated by l10n groups
|
|
Reporter | |
Comment 3•11 years ago
|
||
Since it's far from the last comment, Wayne has done his patch and pushed the Pull Request. So I would take this bug for him.
Assignee: nobody → wayne2833
|
Assignee | |
Comment 4•11 years ago
|
||
Use "grep" to search and fix 2 places: settings/index.html and locales/settings.en-US.properties
Attachment #8362383 -
Flags: review?(arthur.chen)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8362383 [details]
Patch
Thanks for contributing, Wayne! But I'm afraid that this is not a valid bug. SIM manager follows the new title wording policy. Please refer to bug 936398 for details. You can also steal it if you want.
Attachment #8362383 -
Flags: review?(arthur.chen)
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•