Closed
Bug 944639
Opened 11 years ago
Closed 11 years ago
[Download Manager] The complete downloads have to be stored to maintain the history in the download list
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 6 - 12/6
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
The complete downloads have to be stored to maintain the history in the download list
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 1•11 years ago
|
||
Thanks for the review guys
Attachment #8340292 -
Flags: review?(francisco.jordano)
Attachment #8340292 -
Flags: review?(felash)
|
||
Updated•11 years ago
|
Whiteboard: [systemsfe]
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8340292 [details]
Patch v1
+1 to the datastore to be in system as well.
Attachment #8340292 -
Flags: review?(francisco.jordano) → review+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8340292 [details]
Patch v1
looks good, I gave some comments on the PR.
I don't give the r+ because I can't apply it on any codebase that I have right now, but I would have given it otherwise. (with nits ;) ).
Attachment #8340292 -
Flags: feedback+
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8340292 [details]
Patch v1
r=me with non-blocking comments
I'd really want to use sinon instead of using an ad hoc mock.
Attachment #8340292 -
Flags: review?(felash) → review+
|
|
||
Updated•11 years ago
|
Flags: needinfo?(felash)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Blocks: fxos-download-mgr
|
|
||
Updated•11 years ago
|
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in
before you can comment on or make changes to this bug.
Description
•