Closed
Bug 945074
Opened 11 years ago
Closed 11 years ago
give nsTextFrames within continuing nsFirstLetter frames a style context that inherits from what the nsFirstLetter inherits from
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
When we create a continuing nsTextFrame as part of the initial reflow of an nsFirstLetterFrame, we restyle the new nsTextFrame so that it doesn't have the ::first-line style. This is done in nsFirstLetterFrame::DrainOverflowFrames. However, we give it a style context that inherits from the continuing nsFirstLetterFrame, rather than inheriting from whatever the nsFirstLetterFrame inherits from. Later on, a restyle will fix up this style context inheritance, but it would be better to get it right from the start. (Especially as once bug 931668 is complete, we may not get to restyle the nsTextFrame.)
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8340845 -
Flags: review?(dbaron)
Comment 2•11 years ago
|
||
Comment on attachment 8340845 [details] [diff] [review]
patch
r=dbaron; sorry for the delay
Attachment #8340845 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•