Closed Bug 945256 Opened 11 years ago Closed 11 years ago

Pref on media.peerconnection.enabled on Firefox OS when audio P2P feature dependencies are complete

Categories

(Core :: WebRTC, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 945066
1.3 C1/1.4 S1(20dec)

People

(Reporter: jsmith, Unassigned)

Details

(Whiteboard: [ft:webrtc])

Turn on media.peerconnection.enabled on Firefox OS when Audio P2P support is feature complete.
Blocks: 923363
Whiteboard: [ft:webrtc]
Update target milestone to sprint 1 of v1.4
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Looks like this isn't ready to be preffed on. I'm seeing none of the data channel tests passing in emulators right now: https://tbpl.mozilla.org/?tree=Try&rev=b0d0d508d054 12571 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/ipc/test_ipc.html | uncaught exception - TypeError: comp.classes['@mozilla.org/special-powers-observer;1'] is undefined at http://mochi.test:8888/tests/dom/media/tests/ipc/test_ipc.html:125 12643 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudio.html | Test timed out. 12715 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudioVideo.html | Test timed out. 12777 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudioVideoCombined.html | Test timed out. 12829 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html | Test timed out. 12830 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up. 12831 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 151 remaining tests. 12835 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html finished in a non-clean fashion, probably because it didn't call SimpleTest.finish() 12-14 00:55:40.668 706 706 I GeckoDump: 12571 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/ipc/test_ipc.html | uncaught exception - TypeError: comp.classes['@mozilla.org/special-powers-observer;1'] is undefined at http://mochi.test:8888/tests/dom/media/tests/ipc/test_ipc.html:125 12-14 01:00:51.648 706 706 I GeckoDump: 12643 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudio.html | Test timed out. 12-14 01:06:22.138 706 706 I GeckoDump: 12715 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudioVideo.html | Test timed out. 12-14 01:11:52.449 706 706 I GeckoDump: 12777 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudioVideoCombined.html | Test timed out. 12-14 01:17:22.488 706 706 I GeckoDump: 12829 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html | Test timed out. 12-14 01:17:22.508 706 706 I GeckoDump: 12830 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up. 12-14 01:17:22.538 706 706 I GeckoDump: 12831 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 151 remaining tests. 12-14 01:17:23.858 706 706 I GeckoDump: 12835 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html finished in a non-clean fashion, probably because it didn't call SimpleTest.finish() It looks like we're timing out consistently during this command - PC_REMOTE_SET_LOCAL_DESCRIPTION.
Depends on: 950317
We shouldn't turn on dom/media/tests/ipc/test_ipc.html on b2g mochitest because it need platform to support embedding a remote iframe in content process.
The timeout problem is because we cannot get the IP address from b2g NetworkManager while running emulator mochitest. Therefore, we cannot have the candidate address in SDP. On emulator, we one have eth0 setup and the address is only notified to b2g NetworkManager while we turn on 3G data on emulator. Steven and I are trying to get a correct network setup up for emulator mochitest.
As SC says, the problem here is that the emulators are not providing us a network interface that we can use. The eventual result is that we don't have any IP addresses in the ICE candidates and therefore we can't set up a connection. This is actually the expected current behavior when we have no IP addresses. There's probably some way to make the tests show a failure here rather than a timeout (look for ice state to not be failed?) but I haven't checked.
Depends on: 950406
Blocks: b2g-webrtc
No longer depends on: 950359
Depends on: 952220
Depends on: 952237
Depends on: 952251
No longer depends on: 952251
No longer depends on: 952237
No longer depends on: 952220
This is being fixed as part of bug 945066
No longer blocks: b2g-webrtc, 923363
Status: NEW → RESOLVED
Closed: 11 years ago
No longer depends on: 950317, 950406
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.