Closed
Bug 945617
Opened 11 years ago
Closed 3 years ago
The notification bar for hidden plugins shows up when blocking non-hidden plugins
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Core Graveyard
Plug-ins
Tracking
(firefox26 unaffected, firefox27 affected, firefox28 affected)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox26 | --- | unaffected |
| firefox27 | --- | affected |
| firefox28 | --- | affected |
People
(Reporter: pauly, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
STR:
1. Have Flash on 'Always activate'
2. Open a youtube video
3. Block the plugin from the CTP doorhanger
AR: The notification bar for hidden plugins shows up, even if there is no hidden plugin
Regression of bug 941714.
|
Reporter | |
Updated•11 years ago
|
status-firefox26:
--- → unaffected
status-firefox27:
--- → affected
status-firefox28:
--- → affected
|
||
Updated•11 years ago
|
Assignee: nobody → georg.fritzsche
Priority: -- → P3
Keywords: regression
|
|
||
Comment 1•11 years ago
|
||
In this case we hit a test where the plugin has no overlay:
http://hg.mozilla.org/mozilla-central/annotate/85196889c598/browser/base/content/browser-plugins.js#l928
... this *would* mean we show the bar for a short time, but when "PluginBindingAttached" is fired, we end up arond here with aShowNow=false:
http://hg.mozilla.org/mozilla-central/annotate/85196889c598/browser/base/content/browser-plugins.js#l854
... so we're not updating anything. This is changed by this partial fix.
This still leaves the bar showing up for a bit though. It seems like we should move the check from bug 941714 to the CTP-event handling code, but that currently doesn't cover every situation (e.g. "block"->"allownow"->"block" doesn't trigger another event like "PluginBindingAttached").
|
|
||
Updated•11 years ago
|
Assignee: georg.fritzsche → nobody
Flags: firefox-backlog?
|
||
Updated•11 years ago
|
Flags: firefox-backlog? → firefox-backlog+
|
||
Comment 2•3 years ago
|
||
Resolving as wont fix, plugin support deprecated in Firefox 85.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
|
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•