Closed Bug 945734 Opened 11 years ago Closed 9 years ago

Use "invalid argument" status for wrong screen orientation

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox48 fixed, firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

MozReview Request: Bug 945734 - Correct argument error in GeckoDriver#setScreenOrientation; r?automatedtester
(deleted), text/x-review-board-request
automatedtester
: review+
Details
To distinguish between the general fallback WebDriverException/ MarionetteException when the user sends an invalid screen orientation to setScreenOrientation, we should use a new status code “invalid argument”. See the W3C issue tracker for the discussion: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23950
Attachment #8750783 - Flags: review?(dburns) → review+
Comment on attachment 8750783 [details] MozReview Request: Bug 945734 - Correct argument error in GeckoDriver#setScreenOrientation; r?automatedtester https://reviewboard.mozilla.org/r/51623/#review48521
Comment on attachment 8750783 [details] MozReview Request: Bug 945734 - Correct argument error in GeckoDriver#setScreenOrientation; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51623/diff/1-2/
Assignee: nobody → ato
Keywords: ateam-marionette-server
https://hg.mozilla.org/mozilla-central/rev/f2815dd0ea7e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: