Closed
Bug 945820
Opened 11 years ago
Closed 11 years ago
replace es_app_to_dict with AppSerializer
Categories
(Marketplace Graveyard :: API, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-01-28
People
(Reporter: ashort, Assigned: mat)
References
Details
(Whiteboard: [qa+])
We have a DRF-based serializer for apps used in the normal resource; we should use it (or a subclass of it) to replace the old ES serializer.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → ashort
Priority: -- → P2
Assignee | ||
Comment 2•11 years ago
|
||
Note: would be a good idea to add a test making sure we don't do any additional db queries when using the serializer.
Also, translations are going to be a problem, you'll probably need a custom field to get the same behaviour as TranslationSerializerField() in ES. That might be for another bug.
Comment 3•11 years ago
|
||
I filed bug 947291.
Assignee | ||
Updated•11 years ago
|
Assignee: ashort → mpillard
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•11 years ago
|
||
Fixed in https://github.com/mozilla/zamboni/commit/88a59209664f522e1b767425f3fd8f1cd945ae61
STR:
- Submit an app. Be sure to fill in as much data as possible. In particular, set the release notes to something and as an admin, set the region banner message to something.
- Search for apps looking for the one you just submitted
- Load the detail page for one of the apps in the results
- Compare that detail page with the one you get when you reload (you might want to open a new browser window to easily compare the two - but in that case, make sure one details page is loaded from clicking the search results and one is loaded from the direct details page URL)
- Repeat for apps in different states: packaged app, hosted app, premium app, free app, app with upsell, app with content ratings.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [qa+]
Target Milestone: --- → 2014-01-28
Comment 5•11 years ago
|
||
Version notes for packaged apps are seen only after reload : http://screencast.com/t/pTKaxVJVV
Log ID: 7a6a5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•11 years ago
|
||
Version notes fixed in https://github.com/mozilla/zamboni/commit/f9eacd07bd6c01c36e12b4a82d39184d7a89ccce
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
For a free app, the Privacy Policy button is missing after a reload : http://screencast.com/t/ePK73qHgZS82
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Verified as fixed : http://screencast.com/t/z3vjURvIjLU
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•