Closed
Bug 945871
Opened 11 years ago
Closed 11 years ago
Remove the security.ssl3.ecdh_* preferences
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: briansmith, Assigned: steffen.wilberg)
References
Details
(Whiteboard: [good first bug][mentor=briansmith])
Attachments
(1 file)
|
(deleted),
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #917047 +++
In the patch for bug 942729, I added this comment:
// XXX: This assumes that all TLS_DH_* and TLS_ECDH_* cipher suites
// are disabled.
I was intending to remove the security.ssl3.ecdh_* preferences in order to ensure that that assumption is valid, but I forgot.
Basically, we need to remove these preferences from netwerk/base/public/security-prefs.js and the mention of them in security/manager/ssl/src/nsNSSComponent.cpp.
NOTE: Do not remove the security.ssl3.ecdhe_* preferences!
|
Assignee | |
Comment 1•11 years ago
|
||
What about http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSCallbacks.cpp#1098 ?
Assignee: nobody → steffen.wilberg
Attachment #8341970 -
Flags: review?(brian)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8341970 [details] [diff] [review]
remove-ecdh.diff
Review of attachment 8341970 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8341970 -
Flags: review?(brian) → review+
|
|
Reporter | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e505d54ea6
Thanks for the patch.
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•