Closed
Bug 946116
Opened 11 years ago
Closed 11 years ago
security/manager/ssl/src/nsNSSCallbacks.cpp: [-Wunused-variable] unused variable 'isResumedSession'
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
Bug 942729 stopped passing isResumedSession to SetHandshakeCompleted(), but forgot to remove the now unused variable isResumedSession.
Attachment #8342213 -
Flags: review?(brian)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8342213 [details] [diff] [review]
remove-isResumedSession-variable.patch
Review of attachment 8342213 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for catching this. Looks like we need to turn on WARNINGS_AS_ERRORS for non-Windows and Windows builds in PSM.
Attachment #8342213 -
Flags: review?(brian) → review+
|
|
||
Updated•11 years ago
|
Severity: normal → trivial
Component: Security → Security: PSM
OS: Mac OS X → All
Hardware: x86 → All
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•