Closed
Bug 946181
Opened 11 years ago
Closed 11 years ago
[l10n] Rename entities switch-to-metro-button.label and switch-to-metro-button.tooltiptext to reflect updated content
Categories
(Firefox :: Toolbars and Customization, defect, P2)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: flod, Assigned: emtwo)
References
Details
(Whiteboard: [block28] [l10n] p=1[qa-])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Changeset landed in bug 944828
https://hg.mozilla.org/mozilla-central/rev/84139ef0940f
Unless you're fixing a minor typo or grammar error that affects only English, you need to use a new ID for strings.
https://developer.mozilla.org/en-US/docs/Making_String_Changes
Reading bug 944828 it seems like what landed was known to be not finalized, which would be just bad.
|
||
Updated•11 years ago
|
Blocks: metrov1backlog
Whiteboard: [triage]
|
|
||
Updated•11 years ago
|
Assignee: nobody → msamuel
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [triage] → [block28] [l10n] p=1
|
|
||
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 1•11 years ago
|
||
Sorry for the trouble, Francesco
Attachment #8342389 -
Flags: review?(jaws)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8342389 [details] [diff] [review]
v1: Update Metro button names for localization
Instead of changing the button's id, we should allow widgets in CustomizableWidgets.jsm to specify string ids that deviate from the widget ids.
Attachment #8342389 -
Flags: review?(jaws) → review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks for pointing this out, dao. It looks like there is code that already exists allowing me to use label and tooltiptext strings that deviate from the widget id.
Attachment #8342389 -
Attachment is obsolete: true
Attachment #8342460 -
Flags: review?(dao)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8342460 [details] [diff] [review]
v2: Update Metro button string ids localization
Review of attachment 8342460 [details] [diff] [review]:
-----------------------------------------------------------------
Please make sure to include "[Australis]" in the commit message.
Attachment #8342460 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Whiteboard: [block28] [l10n] p=1 → [block28][fixed-in-fx-team] [l10n] p=1
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [block28][fixed-in-fx-team] [l10n] p=1 → [block28] [l10n] p=1
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Whiteboard: [block28] [l10n] p=1 → [block28] [l10n] p=1[qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•