Closed Bug 946335 Opened 11 years ago Closed 11 years ago

about:start no longer displays scrollbars

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Firefox Start
Platform:
All
Windows 8.1
Type:
defect

Tracking

(firefox27 unaffected, firefox28+ verified, firefox29 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 28
Tracking Flags:
Tracking Status
firefox27 --- unaffected
firefox28 + verified
firefox29 --- verified

People

(Reporter: jimm, Assigned: mbrubeck)

References

Details

(Keywords: regression, Whiteboard: [beta28] p=1)

Attachments

(1 file, 1 obsolete file)

patch v2
(deleted), patch
emtwo
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
This regressed in bug 902505. Commenting out updateViewport code fixes it.
Blocks: metrov1backlog
Whiteboard: [triage]
Whiteboard: [triage] → [beta28]
Whiteboard: [beta28] → [beta28] p=0
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Keywords: regression
Attached patch patch (obsolete) (deleted) — — Splinter Review
We were setting an incorrect CSS viewport for the start page, because we shrink the browser on about:start to account for the navbar. While testing this I also noticed that we set "about:home" as an alias for "about:start" in AboutRedirector.js, but weren't treating it like the start page in BrowserUI. This patch also fixes that.
Attachment #8344131 - Flags: review?(msamuel)
Comment on attachment 8344131 [details] [diff] [review] patch There seems to be a timing issue with this patch; it doesn't set the correct viewport when switching from a non-about:start page to an about:start page, probably because the padding hasn't been adjusted yet. Working on a fix.
Attachment #8344131 - Flags: review?(msamuel)
Attached patch patch v2 (deleted) — — Splinter Review
This adds code to update the viewport after we resize the browser when the start page loads or unloads.
Attachment #8344131 - Attachment is obsolete: true
Attachment #8344199 - Flags: review?(msamuel)
Hey Matt, can you provide a point value.
Blocks: metrov1it21
No longer blocks: metrov1backlog
Flags: needinfo?(mbrubeck)
Priority: -- → P2
QA Contact: jbecerra
(In reply to Marco Mucci [:MarcoM] from comment #4) > Hey Matt, can you provide a point value. p=1
Flags: needinfo?(mbrubeck)
Whiteboard: [beta28] p=0 → [beta28] p=1
Comment on attachment 8344199 [details] [diff] [review] patch v2 Review of attachment 8344199 [details] [diff] [review]: ----------------------------------------------------------------- Code looks good to me. Though for some reason, I do see the scrollbar with a pull from this morning without the patch. Not sure if it's perhaps the screen resolution affecting it or something else? But ok if it works for you.
Attachment #8344199 - Flags: review?(msamuel) → review+
https://hg.mozilla.org/mozilla-central/rev/5e20f6d0c911
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Comment on attachment 8344199 [details] [diff] [review] patch v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 902505 User impact if declined: Can't scroll Metro start page with mouse. Testing completed (on m-c, etc.): Baked on m-c since 12/9. Risk to taking this patch (and alternatives if risky): Low-risk Metro-only patch. String or IDL/UUID changes made by this patch: None.
Attachment #8344199 - Flags: approval-mozilla-aurora?
Attachment #8344199 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: Firefox 29 → Firefox 28
Verified using latest nightly and latest aurora builds on Windows 8.1 (32bit and 64bit). The scrollbars are now shown on about:start.
Status: RESOLVED → VERIFIED
status-firefox28: fixed → verified
status-firefox29: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: