Closed
Bug 946480
Opened 11 years ago
Closed 11 years ago
Run adb remount when installing apps
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [c= p=1 s=2013.12.06 u=])
Attachments
(2 files)
In bug 945903, we changed the default installation directory. Pushing apps after a make reset-gaia works fine, until you reboot the system. In this case the /system directory is now read-only and you can't push apps to it with make install-gaia APP=____ anymore.
Pushing manifest.webapp application.zip for homescreen...
failed to copy 'profile/webapps/homescreen.gaiamobile.org/manifest.webapp' to '/system/b2g/webapps/homescreen.gaiamobile.org/manifest.webapp': Read-only file system
Assignee | ||
Comment 1•11 years ago
|
||
Hi Yuren - think you could give this a quick review? In this PR I run adb remount whenever installing an app. This isn't necessary 100% of the time, but it seems to be pretty quick so I don't think it's too terrible. Please let me know if you have any better ideas.
Attachment #8342672 -
Flags: review?(yurenju.mozilla)
Comment 2•11 years ago
|
||
Comment on attachment 8342672 [details]
Pull request - run adb remount when installing apps
we always need adb remount if we execute |make install-gaia|, please add a new make rule |adb-remount| and let |install-gaia| depend on it.
Attachment #8342672 -
Flags: review?(yurenju.mozilla)
Comment 3•11 years ago
|
||
seems a little bit critial, steal it.
Attachment #8342825 -
Flags: review?(timdream)
Updated•11 years ago
|
Assignee: kgrandon → yurenju.mozilla
Updated•11 years ago
|
Attachment #8342825 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Hmm, I don't really think that it was *that* critical, or critical to steal for a nit, but that's fine I suppose. Next time I would appreciate if you could check with me first. Thanks for that patch though!
Assignee | ||
Comment 5•11 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/6a20f5a8104e31e4dedf2fb4ce315ecbeb6d83a3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
Oh, Sorry for that. I think you are sleeping and you will fix this nit tomorrow, that's why I steal it.
Sorry again.
Updated•11 years ago
|
Assignee: yurenju.mozilla → kgrandon
Whiteboard: [c= p=1 s= u=] → [c= p=1 s=2013.12.06 u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•