Closed
Bug 946589
Opened 11 years ago
Closed 11 years ago
B2G RIL: follow-up to bug 944225 - remove 'ril.radio.preferredNetworkType' setting handler
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed)
Tracking | Status | |
---|---|---|
b2g-v1.3T | --- | fixed |
People
(Reporter: jessica, Assigned: edgar)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
After gaia swtiches using the new web api for setting/getting preferred network type, we should remove the 'ril.radio.preferredNetworkType' setting handler in gecko. Please refer to bug 944225 and bug 946548.
Reporter | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
I guess it is safe to remove the 'ril.radio.preferredNetworkType' handler now.
Assignee: nobody → echen
Assignee | ||
Comment 2•11 years ago
|
||
Reporter | ||
Comment 3•11 years ago
|
||
Now that 'ril.radio.preferredNetworkType' is not used anymore, we can't preserve user's selection after power cycle. Some modems will keep this setting, I tested on Buri and it returns the previous selected network type after reboot, but Fugu does not. I am not sure what is the expected behavior?
Anyway, the 'ril.radio.preferredNetworkType' setting is broken, it's always the default one on boot-up cause nobody sets it now. So, I think it's safe to remove it. Thank you! :)
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Jessica Jong [:jjong] [:jessica] from comment #3)
> Now that 'ril.radio.preferredNetworkType' is not used anymore, we can't
> preserve user's selection after power cycle. Some modems will keep this
For preserving user's selection, I think this should be handled in Gaia side (maybe system app?), just like the airplane mode [1].
Thank you.
[1] Please see https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/airplane_mode.js
> setting, I tested on Buri and it returns the previous selected network type
> after reboot, but Fugu does not. I am not sure what is the expected behavior?
> Anyway, the 'ril.radio.preferredNetworkType' setting is broken, it's always
> the default one on boot-up cause nobody sets it now. So, I think it's safe
> to remove it. Thank you! :)
Assignee | ||
Updated•11 years ago
|
Attachment #8374823 -
Flags: review?(htsai)
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Jessica Jong [:jjong] [:jessica] from comment #3)
> Now that 'ril.radio.preferredNetworkType' is not used anymore, we can't
> preserve user's selection after power cycle. Some modems will keep this
> setting, I tested on Buri and it returns the previous selected network type
> after reboot, but Fugu does not. I am not sure what is the expected behavior?
> Anyway, the 'ril.radio.preferredNetworkType' setting is broken, it's always
> the default one on boot-up cause nobody sets it now. So, I think it's safe
> to remove it. Thank you! :)
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #4)
> For preserving user's selection, I think this should be handled in Gaia side
> (maybe system app?), just like the airplane mode [1].
>
> Thank you.
>
> [1] Please see
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/airplane_mode.
> js
Please see bug 974253. Thank you.
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8374823 [details] [diff] [review]
Patch, v1
GECKO_PREFERRED_NETWORK_TYPE_DEFAULT seems redundant, we should remove this as well.
Attachment #8374823 -
Flags: review?(htsai)
Assignee | ||
Comment 8•11 years ago
|
||
Remove GECKO_PREFERRED_NETWORK_TYPE_DEFAULT as well.
Attachment #8378162 -
Flags: review?(htsai)
Assignee | ||
Updated•11 years ago
|
Attachment #8374823 -
Attachment is obsolete: true
Comment 9•11 years ago
|
||
Comment on attachment 8378162 [details] [diff] [review]
Patch, v2
Review of attachment 8378162 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8378162 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 10•11 years ago
|
||
Nominate for 1.3T as it blocks bug 974253 which is a 1.3T blocker.
blocking-b2g: --- → 1.3T?
Updated•11 years ago
|
blocking-b2g: 1.3T? → 1.3T+
Comment 11•11 years ago
|
||
Hi Edgar, is this bug ready for patch landing? thanks
Flags: needinfo?(echen)
Assignee | ||
Comment 12•11 years ago
|
||
(In reply to Joe Cheng [:jcheng] from comment #11)
> Hi Edgar, is this bug ready for patch landing? thanks
Yes, I will land it after passing the test of try server. Thank you.
Flags: needinfo?(echen)
Assignee | ||
Comment 13•11 years ago
|
||
Rebase only.
Attachment #8378162 -
Attachment is obsolete: true
Attachment #8390267 -
Flags: review+
Assignee | ||
Comment 14•11 years ago
|
||
Assignee | ||
Comment 16•11 years ago
|
||
Comment 17•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
Comment 18•11 years ago
|
||
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•